Bug 224761

Summary: Add more GPUProcess release logging to facilitate debugging
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren, kkinnunen, lingcherd_ho, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-04-19 08:02:09 PDT
Add more GPUProcess release logging to facilitate debugging.
Attachments
Patch (2.73 KB, patch)
2021-04-19 08:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-04-19 08:03:04 PDT
Created attachment 426420 [details] Patch
Darin Adler
Comment 2 2021-04-19 09:28:21 PDT
Comment on attachment 426420 [details] Patch Is it ever a good idea to log pointer values in a release build?
Chris Dumez
Comment 3 2021-04-19 09:29:31 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 426420 [details] > Patch > > Is it ever a good idea to log pointer values in a release build? This is our common pattern thus far. E.g.: #define RELEASE_LOG_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_IF(isAlwaysOnLoggingAllowed(), channel, "%p - [pageProxyID=%" PRIu64 ", webPageID=%" PRIu64 ", PID=%i] WebPageProxy::" fmt, this, m_identifier.toUInt64(), m_webPageID.toUInt64(), m_process->processIdentifier(), ##__VA_ARGS__) #define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_ERROR_IF(isAlwaysOnLoggingAllowed(), channel, "%p - [pageProxyID=%" PRIu64 ", webPageID=%" PRIu64 ", PID=%i] WebPageProxy::" fmt, this, m_identifier.toUInt64(), m_webPageID.toUInt64(), m_process->processIdentifier(), ##__VA_ARGS__)
EWS
Comment 4 2021-04-19 09:46:51 PDT
Committed r276257 (236739@main): <https://commits.webkit.org/236739@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426420 [details].
Ling Ho
Comment 5 2021-04-23 03:03:19 PDT
rdar://76849207
Note You need to log in before you can comment on or make changes to this bug.