Bug 224748

Summary:

Update html/rendering/replaced-elements/attributes-for-embedded-content-and-images/ tests from WPT

Product:

WebKit

Reporter:

cathiechen <cathiechen>

Component:

Images

Assignee:

cathiechen <cathiechen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, eric.carlson, ews-watchlist, glenn, jer.noble, lingcherd_ho, philipj, rbuis, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

224197

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

cathiechen

Reported 2021-04-19 04:41:06 PDT

Update mapping width and height as the default aspect ratio tests from WPT

Attachments
Patch (37.38 KB, patch) 2021-04-19 04:49 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (37.45 KB, patch) 2021-04-19 10:35 PDT, cathiechen	no flags	Details Formatted Diff Diff
Patch (39.30 KB, patch) 2021-04-20 02:24 PDT, cathiechen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

cathiechen

Comment 1 2021-04-19 04:49:22 PDT

Created attachment 426407 [details] Patch

Rob Buis

Comment 2 2021-04-19 05:03:24 PDT

Comment on attachment 426407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426407&action=review > LayoutTests/imported/w3c/ChangeLog:8 > + Update the tests for "mapping attribute width and height as the implicit aspect ratio" which are based on the latest agreement. Can you add WPT SHA this is based on?

cathiechen

Comment 3 2021-04-19 06:18:24 PDT

Comment on attachment 426407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426407&action=review >> LayoutTests/imported/w3c/ChangeLog:8 >> + Update the tests for "mapping attribute width and height as the implicit aspect ratio" which are based on the latest agreement. > > Can you add WPT SHA this is based on? Done! Thanks:)

cathiechen

Comment 4 2021-04-19 10:35:29 PDT

Created attachment 426443 [details] Patch

Rob Buis

Comment 5 2021-04-19 22:27:57 PDT

Comment on attachment 426443 [details] Patch The SHA should be shorter, for now it is okay, but next time please remember :)

cathiechen

Comment 6 2021-04-20 02:24:46 PDT

Created attachment 426528 [details] Patch

cathiechen

Comment 7 2021-04-20 02:27:47 PDT

(In reply to Rob Buis from comment #5) > Comment on attachment 426443 [details] > Patch > > The SHA should be shorter, for now it is okay, but next time please remember > :) Done! Thanks:) BTW, I noticed that picture-aspect-ratio.html is flaky, so I added it to LayoutTests/TestExpectations.

EWS

Comment 8 2021-04-20 03:19:28 PDT

Committed r276296 (236778@main): <https://commits.webkit.org/236778@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426528 [details].

Ling Ho

Comment 9 2021-04-23 02:53:38 PDT

rdar://76890554

Note You need to log in before you can comment on or make changes to this bug.