Summary: | Update html/rendering/replaced-elements/attributes-for-embedded-content-and-images/ tests from WPT | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | cathiechen <cathiechen> | ||||||||
Component: | Images | Assignee: | cathiechen <cathiechen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | clopez, eric.carlson, ews-watchlist, glenn, jer.noble, lingcherd_ho, philipj, rbuis, sergio, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 224197 | ||||||||||
Attachments: |
|
Description
cathiechen
2021-04-19 04:41:06 PDT
Created attachment 426407 [details]
Patch
Comment on attachment 426407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426407&action=review > LayoutTests/imported/w3c/ChangeLog:8 > + Update the tests for "mapping attribute width and height as the implicit aspect ratio" which are based on the latest agreement. Can you add WPT SHA this is based on? Comment on attachment 426407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426407&action=review >> LayoutTests/imported/w3c/ChangeLog:8 >> + Update the tests for "mapping attribute width and height as the implicit aspect ratio" which are based on the latest agreement. > > Can you add WPT SHA this is based on? Done! Thanks:) Created attachment 426443 [details]
Patch
Comment on attachment 426443 [details]
Patch
The SHA should be shorter, for now it is okay, but next time please remember :)
Created attachment 426528 [details]
Patch
(In reply to Rob Buis from comment #5) > Comment on attachment 426443 [details] > Patch > > The SHA should be shorter, for now it is okay, but next time please remember > :) Done! Thanks:) BTW, I noticed that picture-aspect-ratio.html is flaky, so I added it to LayoutTests/TestExpectations. Committed r276296 (236778@main): <https://commits.webkit.org/236778@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426528 [details]. |