Bug 224739

Summary: [WPE] Allow defining custom repo and branch for Cog checkout
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, ews-watchlist, glenn, gyuyoung.kim, jbedard, pnormand, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch none

Lauro Moura
Reported 2021-04-18 20:16:41 PDT
[WPE] Allow defining custom repo and branch for Cog checkout
Attachments
Patch (4.02 KB, patch)
2021-04-18 20:17 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Updated patch (8.57 KB, patch)
2021-04-19 13:09 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-04-18 20:17:38 PDT
Created attachment 426392 [details] Patch
Lauro Moura
Comment 2 2021-04-18 20:26:41 PDT
Comment on attachment 426392 [details] Patch The check in "use_cog" is not enough. A leftover cog binary from a previous build will lead to implying Cog is enabled.
Lauro Moura
Comment 3 2021-04-19 13:09:20 PDT
Created attachment 426467 [details] Updated patch Updated version with WPE_BROWSER envvar to allow selecting between cog and minibrowser. Makes it easier to switch between both.
EWS
Comment 4 2021-04-21 02:57:20 PDT
Committed r276355 (236833@main): <https://commits.webkit.org/236833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426467 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-23 00:38:48 PDT
<rdar://problem/77060233>
Note You need to log in before you can comment on or make changes to this bug.