| Summary: | [WPE] Allow defining custom repo and branch for Cog checkout | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
| Component: | New Bugs | Assignee: | Lauro Moura <lmoura> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, aperez, bugs-noreply, ews-watchlist, glenn, gyuyoung.kim, jbedard, pnormand, ryuan.choi, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Lauro Moura
2021-04-18 20:16:41 PDT
Created attachment 426392 [details]
Patch
Comment on attachment 426392 [details]
Patch
The check in "use_cog" is not enough. A leftover cog binary from a previous build will lead to implying Cog is enabled.
Created attachment 426467 [details]
Updated patch
Updated version with WPE_BROWSER envvar to allow selecting between cog and minibrowser. Makes it easier to switch between both.
Committed r276355 (236833@main): <https://commits.webkit.org/236833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426467 [details]. |