Bug 22473

Summary: Unroll the regexp matching loop by 1
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch sam: review+

Geoffrey Garen
Reported 2008-11-24 17:03:44 PST
Patch coming.
Attachments
patch (4.41 KB, patch)
2008-11-24 17:03 PST, Geoffrey Garen 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2008-11-24 17:03:55 PST
Created attachment 25461 [details] patch
Sam Weinig
Comment 2 2008-11-24 20:12:05 PST
Comment on attachment 25461 [details] patch > -void Generator::generateLoopIfNotEndOfInput(JmpDst target) > +// For the sake of end-of-line assertions, we treat one-past-the-end as if it > +// were part of the input string. > +void Generator::generateJumpIfEndOfInput(JmpSrcVector& failures) > +{ > + __ cmpl_rr(Generator::length, Generator::index); The Generator:: should not be needed here. r=me
Geoffrey Garen
Comment 3 2008-11-24 22:10:22 PST
Committed revision 38745.
Note You need to log in before you can comment on or make changes to this bug.