| Summary: | RemoteImageDecoderAVFManager should never re-launch the GPUProcess on destruction | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Media | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224556 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2021-04-17 15:35:42 PDT
Created attachment 426353 [details]
Patch
Comment on attachment 426353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426353&action=review > Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:82 > + // FIXME: Do we need to do more when m_remoteImageDecoders is not empty to re-create them? You’d think they’d either need to fail or get re-created. (In reply to Darin Adler from comment #2) > Comment on attachment 426353 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426353&action=review > > > Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:82 > > + // FIXME: Do we need to do more when m_remoteImageDecoders is not empty to re-create them? > > You’d think they’d either need to fail or get re-created. Yes, we likely need to do something. I will ping the media team about this pre-existing issue. Committed r276212 (236694@main): <https://commits.webkit.org/236694@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426353 [details]. (In reply to Chris Dumez from comment #3) > (In reply to Darin Adler from comment #2) > > Comment on attachment 426353 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=426353&action=review > > > > > Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:82 > > > + // FIXME: Do we need to do more when m_remoteImageDecoders is not empty to re-create them? > > > > You’d think they’d either need to fail or get re-created. > > Yes, we likely need to do something. I will ping the media team about this > pre-existing issue. Yes. Filed webkit.org/b/224766 to track that. |