| Summary: | [clang 11] Remove warning when converting WebCore::maxValueForCssLength from int to float | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Component: | Platform | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | Basuke.Suzuki, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, pnormand, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 204834 | ||||||||
| Attachments: |
|
||||||||
Created attachment 426323 [details]
PATCH
Created attachment 426340 [details]
PATCH
Comment on attachment 426340 [details]
PATCH
R=me assuming the boys are happy
(In reply to Chris Dumez from comment #3) > Comment on attachment 426340 [details] > PATCH > > R=me assuming the boys are happy Thanks! Committed r276205 (236687@main): <https://commits.webkit.org/236687@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426340 [details]. *** Bug 213972 has been marked as a duplicate of this bug. *** |
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-136.cpp:8: In file included from WebCore/DerivedSources\StyleBuilderGenerated.cpp:10: ../../Source/WebCore/style\StyleBuilderConverter.h:1215:97: warning: implicit conversion from 'const int' to 'float' changes value from 33554429 to 33554428 [-Wimplicit-const-int-float-conversion] wordSpacing = Length(clampTo<float>(primitiveValue.doubleValue(), minValueForCssLength, maxValueForCssLength), LengthType::Percent); ~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ 1 warning generated.