Bug 224714

Summary: [clang 11] Remove warning when converting WebCore::maxValueForCssLength from int to float
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 204834    
Attachments:
Description Flags
PATCH
cdumez: review+
PATCH none

Basuke Suzuki
Reported 2021-04-16 22:21:08 PDT
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-136.cpp:8: In file included from WebCore/DerivedSources\StyleBuilderGenerated.cpp:10: ../../Source/WebCore/style\StyleBuilderConverter.h:1215:97: warning: implicit conversion from 'const int' to 'float' changes value from 33554429 to 33554428 [-Wimplicit-const-int-float-conversion] wordSpacing = Length(clampTo<float>(primitiveValue.doubleValue(), minValueForCssLength, maxValueForCssLength), LengthType::Percent); ~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ 1 warning generated.
Attachments
PATCH (1.99 KB, patch)
2021-04-16 22:34 PDT, Basuke Suzuki 		cdumez: review+
DetailsFormatted DiffDiff
PATCH (2.83 KB, patch)
2021-04-17 11:43 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2021-04-16 22:34:06 PDT
Created attachment 426323 [details] PATCH
Basuke Suzuki
Comment 2 2021-04-17 11:43:51 PDT
Created attachment 426340 [details] PATCH
Chris Dumez
Comment 3 2021-04-17 12:00:42 PDT
Comment on attachment 426340 [details] PATCH R=me assuming the boys are happy
Basuke Suzuki
Comment 4 2021-04-17 12:45:55 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 426340 [details] > PATCH > > R=me assuming the boys are happy Thanks!
EWS
Comment 5 2021-04-17 13:16:29 PDT
Committed r276205 (236687@main): <https://commits.webkit.org/236687@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426340 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-24 15:07:27 PDT
<rdar://problem/77110096>
Brent Fulgham
Comment 7 2022-06-30 16:57:56 PDT
*** Bug 213972 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.