Bug 224706

Summary: [bmalloc] Enable Adaptive Scavenger for Mac
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Michael Saboff
Reported 2021-04-16 17:30:38 PDT
The adaptive scavenger landed in change set r243144, but was later disabled for macOS in r249670 due to a regression found during power testing. It is likely that we can arrive at a different set of adaptive scavenger parameters that provide memory reduction without impacting performance.
Attachments
Patch (26.20 KB, patch)
2021-04-19 09:12 PDT, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2021-04-16 17:31:44 PDT
<rdar://71987791>
Radar WebKit Bug Importer
Comment 2 2021-04-16 17:31:52 PDT
<rdar://problem/76786339>
Michael Saboff
Comment 3 2021-04-19 09:12:27 PDT
Created attachment 426430 [details] Patch
Saam Barati
Comment 4 2021-04-19 09:32:19 PDT
Comment on attachment 426430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426430&action=review > Source/bmalloc/bmalloc/Scavenger.h:113 > +#if BPLATFORM(MAC) maybe also worth it for catalyst?
Michael Saboff
Comment 5 2021-04-19 11:13:12 PDT
(In reply to Saam Barati from comment #4) > Comment on attachment 426430 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426430&action=review > > > Source/bmalloc/bmalloc/Scavenger.h:113 > > +#if BPLATFORM(MAC) > > maybe also worth it for catalyst? One could probably argue good reasons for either the macOS semantics or the every other platform semantics. I'd like to defer this to a future patch after appropriate testing of the two sets of parameters.
Michael Saboff
Comment 6 2021-04-19 11:52:29 PDT
Committed r276266 (236748@main): <https://commits.webkit.org/236748@main>
Note You need to log in before you can comment on or make changes to this bug.