Bug 224705

Summary: Consider removing Expected::operator bool
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED WONTFIX    
Severity: Normal CC: darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review-

Alex Christensen
Reported 2021-04-16 17:16:54 PDT
Consider removing Expected::operator bool
Attachments
Patch (164.93 KB, patch)
2021-04-16 17:19 PDT, Alex Christensen 		achristensen: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-04-16 17:19:23 PDT
Created attachment 426294 [details] Patch
Darin Adler
Comment 2 2021-04-17 17:30:19 PDT
Comment on attachment 426294 [details] Patch Would you consider using "explicit operator bool" instead of removing it entirely? If not, what is making you want to remove it?
Darin Adler
Comment 3 2021-04-17 17:31:06 PDT
Seems like we might want to align with std::expected if we hope to move to it some day.
Alex Christensen
Comment 4 2021-04-19 08:54:52 PDT
There was a discussion in the standardization process about whether it should be included at all. This was to show them what removing it would do to our code. I don't think we should remove it, but this was a useful exercise.
Darin Adler
Comment 5 2021-04-19 09:28:51 PDT
Thanks for explaining!
Note You need to log in before you can comment on or make changes to this bug.