| Summary: | Consider removing Expected::operator bool | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2021-04-16 17:16:54 PDT
Created attachment 426294 [details]
Patch
Comment on attachment 426294 [details]
Patch
Would you consider using "explicit operator bool" instead of removing it entirely? If not, what is making you want to remove it?
Seems like we might want to align with std::expected if we hope to move to it some day. There was a discussion in the standardization process about whether it should be included at all. This was to show them what removing it would do to our code. I don't think we should remove it, but this was a useful exercise. Thanks for explaining! |