Bug 22468

Summary:

Coding style: config.h should only be included in implementation files, not in header

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed addition: mostly made for discussion & enhancement	eric: review-
Updated proposition: add one more example, explains a bit what an implementation file is	eric: review+

Julien Chaffraix

Reported 2008-11-24 14:51:15 PST

See https://bugs.webkit.org/show_bug.cgi?id=22441#c7 for Darin's explanation on that subject.

Attachments
Proposed addition: mostly made for discussion & enhancement (2.39 KB, patch) 2008-11-25 16:01 PST, Julien Chaffraix	eric: review-	Details Formatted Diff Diff
Updated proposition: add one more example, explains a bit what an implementation file is (3.09 KB, patch) 2008-11-26 14:41 PST, Julien Chaffraix	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Julien Chaffraix

Comment 1 2008-11-25 16:01:50 PST

Created attachment 25509 [details] Proposed addition: mostly made for discussion & enhancement

Eric Seidel (no email)

Comment 2 2008-11-25 17:49:35 PST

Comment on attachment 25509 [details] Proposed addition: mostly made for discussion & enhancement I'm not sure it's clear to me from reading what an "implementation" file is. Maybe (.cpp, .c, .mm, etc.) as an aside would help. This sentence is backwards: This guarantees that each header's completeness is tested, +to make sure it can be compiled without requiring any other header files be +included first. "This assures that each header can be compiled without requiring any other header included first." or similar, no need to state "completeness" and then define it. An extra wrong example of HTMLDivElement.h might be helpful. Having HTMLDivElement.cpp unsorted might also be useful. :) Otherwise looks fine. This is a useful change to the style guide.

Julien Chaffraix

Comment 3 2008-11-26 14:41:54 PST

Created attachment 25540 [details] Updated proposition: add one more example, explains a bit what an implementation file is

Eric Seidel (no email)

Comment 4 2008-11-26 14:56:56 PST

Comment on attachment 25540 [details] Updated proposition: add one more example, explains a bit what an implementation file is Looks good. Thanks!

Julien Chaffraix

Comment 5 2008-11-27 17:45:13 PST

Landed in r38824.

Note You need to log in before you can comment on or make changes to this bug.