| Summary: | Deploy Ref/RefPtr/WeakPtr in EditCommand and CompositeEditCommand | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, darin, ews-watchlist, fred.wang, iang, julian_a_gonzalez, koivisto, mifenton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2021-04-16 01:09:47 PDT
Created attachment 426197 [details]
Patch
Comment on attachment 426197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426197&action=review > Source/WebCore/editing/CompositeEditCommand.cpp:1013 > + ([&]() { Are the parethesis necessary? I think just doing [&] { ... }(); works. Also you could consider making it an informatively named lambda, just for documentation purposes. (In reply to Antti Koivisto from comment #2) > Comment on attachment 426197 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426197&action=review > > > Source/WebCore/editing/CompositeEditCommand.cpp:1013 > > + ([&]() { > > Are the parethesis necessary? I think just doing > > [&] { > ... > }(); > > works. That's a good point. Will change. Created attachment 426200 [details]
Patch for landing
(In reply to Antti Koivisto from comment #3) > Also you could consider making it an informatively named lambda, just for > documentation purposes. Will do. Committed r276131 (236626@main): <https://commits.webkit.org/236626@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426200 [details]. |