Bug 224659

Summary: Deploy Ref/RefPtr/WeakPtr in EditCommand and CompositeEditCommand
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, darin, ews-watchlist, fred.wang, iang, julian_a_gonzalez, koivisto, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ryosuke Niwa
Reported 2021-04-16 01:09:47 PDT
Deploy smart pointers.
Attachments
Patch (33.11 KB, patch)
2021-04-16 01:47 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.16 KB, patch)
2021-04-16 02:55 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-04-16 01:47:08 PDT
Created attachment 426197 [details] Patch
Antti Koivisto
Comment 2 2021-04-16 02:44:03 PDT
Comment on attachment 426197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426197&action=review > Source/WebCore/editing/CompositeEditCommand.cpp:1013 > + ([&]() { Are the parethesis necessary? I think just doing [&] { ... }(); works.
Antti Koivisto
Comment 3 2021-04-16 02:46:30 PDT
Also you could consider making it an informatively named lambda, just for documentation purposes.
Ryosuke Niwa
Comment 4 2021-04-16 02:46:53 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 426197 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426197&action=review > > > Source/WebCore/editing/CompositeEditCommand.cpp:1013 > > + ([&]() { > > Are the parethesis necessary? I think just doing > > [&] { > ... > }(); > > works. That's a good point. Will change.
Ryosuke Niwa
Comment 5 2021-04-16 02:55:52 PDT
Created attachment 426200 [details] Patch for landing
Ryosuke Niwa
Comment 6 2021-04-16 02:55:57 PDT
(In reply to Antti Koivisto from comment #3) > Also you could consider making it an informatively named lambda, just for > documentation purposes. Will do.
EWS
Comment 7 2021-04-16 03:21:52 PDT
Committed r276131 (236626@main): <https://commits.webkit.org/236626@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426200 [details].
Radar WebKit Bug Importer
Comment 8 2021-04-24 15:10:00 PDT
<rdar://problem/77110130>
Note You need to log in before you can comment on or make changes to this bug.