Bug 224644

Summary: REGRESSION(r276039) [GTK] Build failures on Ubuntu 18.04
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: JavaScriptCoreAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224616
Bug Depends on: 224646    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Lauro Moura 2021-04-15 20:47:56 PDT 
Failed on the Ubuntu LTS 18.04 (due to be deprecated next week)

lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-68aea4ac-6.cpp.o):UnifiedSource-68aea4ac-6.cpp:function WebCore::getBackingSet(JSC::JSGlobalObject&, JSC::JSObject&): error: undefined reference to 'JSC::HashMapImpl<JSC::HashMapBucket<JSC::HashMapBucketDataKey> >::finishCreation(JSC::JSGlobalObject*, JSC::VM&)'
lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-68aea4ac-6.cpp.o):UnifiedSource-68aea4ac-6.cpp:function WebCore::getBackingMap(JSC::JSGlobalObject&, JSC::JSObject&): error: undefined reference to 'JSC::HashMapImpl<JSC::HashMapBucket<JSC::HashMapBucketDataKeyValue> >::finishCreation(JSC::JSGlobalObject*, JSC::VM&)'
collect2: error: ld returned 1 exit status
Comment 1 Lauro Moura 2021-04-15 21:12:57 PDT 
Created attachment 426180 [details]
Patch
Comment 2 EWS 2021-04-15 21:44:01 PDT 
Committed r276112 (236612@main): <https://commits.webkit.org/236612@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426180 [details].
Comment 3 Mark Lam 2021-04-15 21:52:48 PDT 
Comment on attachment 426180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426180&action=review

> Source/JavaScriptCore/runtime/JSSet.h:28
> +#include "HashMapImplInlines.h"

This is the wrong fix.  We should never #include an Inlines.h file from a .h file.  Only .cpp or Inlines.h file can #include Inlines.h files.  Please revert this and fix this the proper way.
Comment 4 Mark Lam 2021-04-15 21:54:31 PDT 
I'm going to roll this out right now.
Comment 5 WebKit Commit Bot 2021-04-15 21:56:15 PDT 
Re-opened since this is blocked by bug 224646
Comment 6 Radar WebKit Bug Importer 2021-04-15 21:56:22 PDT 
<rdar://problem/76742835>
Comment 7 Lauro Moura 2021-04-15 22:13:38 PDT 
Created attachment 426183 [details]
Patch for landing
Comment 8 EWS 2021-04-15 23:25:37 PDT 
Committed r276119 (236616@main): <https://commits.webkit.org/236616@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426183 [details].