Bug 224617

Summary: AX: inverse role synonyms "presentation" and "none" to make "none" the primary
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, hi, jdiggs, pangle, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
screen shot
none
patch
none
patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description James Craig 2021-04-15 11:20:32 PDT 
AX: inverse role synonyms "presentation" and "none" to make "none" the primary

ARIA "none" has had very good browser support for a number of years, so the ARIA spec is making it the primary role (over the original name "presentation"). Currently "presentation" is the returned role in WebKit's reverse enum lookup (computedRoleString IIRC?). Since "presentation" will be deprecated, the computed role string should return the ARIA 1.1 "none" role, over the 1.0 "presentation" role. The deprecated "presentation" role should remain in WebKit for backwards compatibility.
Comment 1 Radar WebKit Bug Importer 2021-04-15 11:20:46 PDT 
<rdar://problem/76713760>
Comment 2 James Craig 2021-04-15 11:21:07 PDT 
related bug 224615
Comment 3 James Craig 2021-04-15 11:36:37 PDT 
To clarify where this will result in end-user impact... The WebKit Web Inspector Accessibility Node Inspector will return role "none" or "none (computed)" See attached image of that UI.
Comment 4 James Craig 2021-04-15 11:39:21 PDT 
Created attachment 426120 [details]
screen shot
Comment 5 chris fleizach 2021-04-22 11:28:57 PDT 
Created attachment 426831 [details]
patch
Comment 6 Devin Rousso 2021-04-22 12:01:20 PDT 
Comment on attachment 426831 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426831&action=review

> LayoutTests/inspector/audit/run-accessibility-expected.txt:11
> -Result: []
> -Audit teardown...
> +Result: Audit teardown...

This seems scary.  I wouldn't expect this looking at your other changes 🤔
Comment 7 chris fleizach 2021-04-22 12:02:48 PDT 
(In reply to Devin Rousso from comment #6)
> Comment on attachment 426831 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426831&action=review
> 
> > LayoutTests/inspector/audit/run-accessibility-expected.txt:11
> > -Result: []
> > -Audit teardown...
> > +Result: Audit teardown...
> 
> This seems scary.  I wouldn't expect this looking at your other changes 🤔
I agree. I was hoping someone would say, "that looks expected"

I don't understand why it appeared, but will dig into it further
Comment 8 chris fleizach 2021-04-26 12:24:14 PDT 
Created attachment 427078 [details]
patch
Comment 9 Devin Rousso 2021-05-12 16:46:48 PDT 
Comment on attachment 427078 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427078&action=review

rs=me

> Source/WebCore/accessibility/AccessibilityObject.cpp:2182
> +    // http://webkit.org/b/224617 - prefer "none" as the canonical role to be used for presentationals (instead of "presentation"

Rather than have a link to the bugzilla, can you explain inline why this is the way it is (ideally with a link to a spec if possible)?
Comment 10 James Craig 2023-03-21 00:02:09 PDT 
Tagging WPTImpact because this may fail with some of the impending role tests coming with the Interop 2023 Accessibility Investigation.

https://github.com/w3c/core-aam/issues/166
Comment 11 James Craig 2023-03-24 16:16:50 PDT 
FYI the link to the spec change Devin asked for is now in this ARIA Core-AAM patch: 
https://github.com/w3c/core-aam/pull/167/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051R1097
Comment 12 James Craig 2023-03-24 16:19:50 PDT 
Sorry. Diff link is actually:
https://github.com/w3c/core-aam/pull/167/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051R1640

So final link if you reference it in the patch or commit msg is:
https://w3c.github.io/core-aam/#role-map-img
Comment 13 chris fleizach 2023-03-24 16:59:33 PDT 
Created attachment 465579 [details]
Patch
Comment 14 chris fleizach 2023-03-24 17:21:16 PDT 
Created attachment 465580 [details]
Patch
Comment 15 chris fleizach 2023-03-24 23:10:08 PDT 
Created attachment 465584 [details]
Patch
Comment 16 EWS 2023-03-25 15:59:52 PDT 
Committed 262119@main (d5fbadeac7c4): <https://commits.webkit.org/262119@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465584 [details].