Bug 224591

Summary: Deploy Ref/RefPtr in ReplaceSelectionCommand
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, iang, jiewen_tan, julian_a_gonzalez, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Fixed builds ews-feeder: commit-queue-

Ryosuke Niwa
Reported 2021-04-14 20:34:15 PDT
We should use smart pointers everywhere in ReplaceSelectionCommand based on the new rule we came up with.
Attachments
Patch (30.99 KB, patch)
2021-04-14 20:36 PDT, Ryosuke Niwa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Fixed builds (31.30 KB, patch)
2021-04-14 21:03 PDT, Ryosuke Niwa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-04-14 20:36:54 PDT
Created attachment 426071 [details] Patch
Jiewen Tan
Comment 2 2021-04-14 20:49:41 PDT
Comment on attachment 426071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426071&action=review LGTM. r=me. > Source/WebCore/editing/ReplaceSelectionCommand.cpp:562 > + ScriptDisallowedScope::InMainThread scriptDisallowedScope; Why do we need this here?
Ryosuke Niwa
Comment 3 2021-04-14 20:52:09 PDT
(In reply to Jiewen Tan from comment #2) > Comment on attachment 426071 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426071&action=review > > LGTM. r=me. > > > Source/WebCore/editing/ReplaceSelectionCommand.cpp:562 > > + ScriptDisallowedScope::InMainThread scriptDisallowedScope; > > Why do we need this here? Because we're accessing the render objects. We don't want any script execution to happen there.
Ryosuke Niwa
Comment 4 2021-04-14 20:52:44 PDT
Huh, weird. Not sure why we didn't hit that compilation error locally.
Ryosuke Niwa
Comment 5 2021-04-14 21:03:28 PDT
Created attachment 426072 [details] Fixed builds
Ryosuke Niwa
Comment 6 2021-04-14 21:04:38 PDT
Comment on attachment 426072 [details] Fixed builds This has already been reviewed by Jiewen.
Ryosuke Niwa
Comment 7 2021-04-15 00:34:54 PDT
Committed r276006 (236558@main): <https://commits.webkit.org/236558@main>
Radar WebKit Bug Importer
Comment 8 2021-04-15 00:35:16 PDT
<rdar://problem/76689476>
Note You need to log in before you can comment on or make changes to this bug.