Bug 224571

Summary:

Promote `-[WKWebView _themeColor]` SPI to API

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

WebKit API

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, ggaren, hi, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2021-04-14 12:40:23 PDT

Comment 1 Devin Rousso 2021-04-14 12:40:39 PDT

<rdar://problem/75231602>

Comment 2 Devin Rousso 2021-04-14 12:50:35 PDT

Created attachment 426036 [details]
Patch

Comment 3 Geoffrey Garen 2021-04-14 12:56:19 PDT

Comment on attachment 426036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426036&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2985
> -- (CocoaColor *)_themeColor

Don't we still need to keep around the _themeColor variant, to avoid breaking existing binaries that use it?

Two separate but similar concerns here:

(1) We don't want anything that uses _themeColor to break at the moment this lands in a build;

(2) We may want to A/B test new WebKit with old { Insert App Here } when doing perf or correctness bisecting.

Comment 4 Devin Rousso 2021-04-14 14:15:57 PDT

Created attachment 426045 [details]
Patch

Comment 5 Geoffrey Garen 2021-04-14 14:22:05 PDT

Comment on attachment 426045 [details]
Patch

r=me

Comment 6 EWS 2021-04-14 18:26:29 PDT

Committed r275984 (236536@main): <https://commits.webkit.org/236536@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426045 [details].