Summary: | Use OptionSet for MediaProducer::MutedStateFlags | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | berto, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Local Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2021-04-14 08:26:19 PDT
Created attachment 427410 [details]
Patch
Created attachment 427415 [details]
Patch
Created attachment 427418 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 427420 [details]
Patch
Comment on attachment 427420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427420&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1018 > - mutedState = WebCore::MediaProducer::AudioCaptureIsMuted; > + mutedState.add(WebCore::MediaProducer::MutedState::AudioCaptureIsMuted); It looks like this fixes a potential bug, nice! > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1039 > - mutedState = WebCore::MediaProducer::VideoCaptureIsMuted; > + mutedState.add(WebCore::MediaProducer::MutedState::VideoCaptureIsMuted); Ditto (In reply to Eric Carlson from comment #7) > Comment on attachment 427420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427420&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1018 > > - mutedState = WebCore::MediaProducer::AudioCaptureIsMuted; > > + mutedState.add(WebCore::MediaProducer::MutedState::AudioCaptureIsMuted); > > It looks like this fixes a potential bug, nice! > > > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1039 > > - mutedState = WebCore::MediaProducer::VideoCaptureIsMuted; > > + mutedState.add(WebCore::MediaProducer::MutedState::VideoCaptureIsMuted); > > Ditto Good point, I updated the API test accordingly. Created attachment 427541 [details]
Patch for landing
Committed r276892 (237238@main): <https://commits.webkit.org/237238@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427541 [details]. |