Bug 224543

Summary: AudioSourceProviderAVFObjC uses atomic variables but also locks with mutex
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: MediaAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, lingcherd_ho, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2021-04-14 05:58:35 PDT
AudioSourceProviderAVFObjC uses atomic variables but also locks with mutex This makes it hard to understand the code, as the atomic usage seems to be purposeless.
Attachments
Patch (4.73 KB, patch)
2021-04-14 06:00 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-04-14 06:00:49 PDT
Created attachment 425975 [details] Patch
Alexey Proskuryakov
Comment 2 2021-04-15 15:45:27 PDT
Comment on attachment 425975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425975&action=review > Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:378 > + m_writeAheadCount = m_tapDescription->mSampleRate * earlyBy.toDouble(); I looked here as an example, and I don't see any mutex serializing the access.
Kimmo Kinnunen
Comment 3 2021-04-15 22:14:47 PDT
Comment on attachment 425975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425975&action=review >> Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:378 >> + m_writeAheadCount = m_tapDescription->mSampleRate * earlyBy.toDouble(); > > I looked here as an example, and I don't see any mutex serializing the access. Taken up there in the caller, processCallback.
EWS
Comment 4 2021-04-20 04:38:45 PDT
Committed r276301 (236783@main): <https://commits.webkit.org/236783@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425975 [details].
Ling Ho
Comment 5 2021-04-23 02:52:02 PDT
rdar://76893260
Note You need to log in before you can comment on or make changes to this bug.