| Summary: | AudioSourceProviderAVFObjC uses atomic variables but also locks with mutex | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
| Component: | Media | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, jer.noble, lingcherd_ho, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Kimmo Kinnunen
2021-04-14 05:58:35 PDT
Created attachment 425975 [details]
Patch
Comment on attachment 425975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425975&action=review > Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:378 > + m_writeAheadCount = m_tapDescription->mSampleRate * earlyBy.toDouble(); I looked here as an example, and I don't see any mutex serializing the access. Comment on attachment 425975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425975&action=review >> Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:378 >> + m_writeAheadCount = m_tapDescription->mSampleRate * earlyBy.toDouble(); > > I looked here as an example, and I don't see any mutex serializing the access. Taken up there in the caller, processCallback. Committed r276301 (236783@main): <https://commits.webkit.org/236783@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425975 [details]. |