Bug 224534

Summary:

[GTK4] Use a while loop in PlatformWebView::dismissAllPopupMenus()

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, pnormand, webkit-bug-importer

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[fast-cq] Patch	none

Description Carlos Garcia Campos 2021-04-14 01:22:19 PDT

The child might be destroyed during the loop iteration. Using a while loop we ensure we get the next sibling before the current child is destroyed.

Comment 1 Carlos Garcia Campos 2021-04-14 01:25:21 PDT

Created attachment 425960 [details]
[fast-cq] Patch

Comment 2 EWS 2021-04-14 03:03:18 PDT

Committed r275940 (236502@main): <https://commits.webkit.org/236502@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425960 [details].

Comment 3 Radar WebKit Bug Importer 2021-04-14 03:04:14 PDT

<rdar://problem/76637108>

Comment 4 Carlos Garcia Campos 2021-04-14 05:12:40 PDT

Comment on attachment 425960 [details]
[fast-cq] Patch

I tried fast-cq because I thought it hadn't landed when I saw the cq-. Clearing flags to avoid more confusion