| Summary: | Allow text tracks to purge cues outside of the buffered range | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | calvaris, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Carlson
2021-04-13 09:56:38 PDT
Created attachment 425882 [details]
Patch
Comment on attachment 425882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425882&action=review r=me with nit: > Source/WebCore/html/track/InbandDataTextTrack.h:48 > + bool purgesCuesFromUnbufferedRanges() const final { return true; } Nit: This confused me on initial reading, which I parsed as "purge cues from unbuffered ranges". Maybe "shouldPurgeCuesFromUnbufferedRanges()"? Created attachment 425895 [details]
Patch for landing
Created attachment 425921 [details]
Patch for landing
Created attachment 425982 [details]
Patch for landing
Committed r275949 (236509@main): <https://commits.webkit.org/236509@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425982 [details]. |