Bug 224454

Summary: REGRESSION (r275792): [ iOS wk2 ] TestWebKitAPI.IndexedDB.DatabaseProcessKill is a flakey timeout
Product: WebKit Reporter: Robert Jenner <jenner>
Component: WebKit APIAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, sihui_liu, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review+, ews-feeder: commit-queue-

Robert Jenner
Reported 2021-04-12 14:37:54 PDT
TestWebKitAPI.IndexedDB.DatabaseProcessKill is a flakey timeout on iOS wk2. HISTORY: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.IndexedDB.DatabaseProcessKill Link to stdio file where timeout is noted: https://build.webkit.org/#/builders/28/builds/910/steps/11/logs/stdio It is flakey, but it does timeout more than it passes.
Attachments
Patch (5.18 KB, patch)
2021-04-12 20:12 PDT, Simon Fraser (smfr) 		beidson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-04-12 14:38:11 PDT
<rdar://problem/76558602>
Robert Jenner
Comment 2 2021-04-12 16:01:06 PDT
This appears to be trivially reproducible with a release build, but does not appear to affect debug or production builds. As such, I did reproduce the failure at iOS Release ToT using the following test: run-api-tests --ios-simulator TestWebKitAPI.IndexedDB.DatabaseProcessKill --child-process=50 Note that it is only occurring on release, and will pass on Production and Debug builds. I was also able to verify a regress point. The timeouts occur in r275792, and did not occur in 275791. It appears this changeset caused the timeouts: https://trac.webkit.org/changeset/275792/webkit
Simon Fraser (smfr)
Comment 3 2021-04-12 20:12:54 PDT
Created attachment 425825 [details] Patch
Sihui Liu
Comment 4 2021-04-12 22:08:41 PDT
Comment on attachment 425825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425825&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:85 > [webView _test_waitForDidFinishNavigation]; Why not just replace this with TestWebKitAPI::Util::run(&receivedScriptMessage)?
Simon Fraser (smfr)
Comment 5 2021-04-13 08:57:39 PDT
Comment on attachment 425825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425825&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:85 >> [webView _test_waitForDidFinishNavigation]; > > Why not just replace this with TestWebKitAPI::Util::run(&receivedScriptMessage)? Maybe it could just be removed. I'll test.
Simon Fraser (smfr)
Comment 6 2021-04-13 09:54:48 PDT
https://trac.webkit.org/changeset/275890/webkit
Note You need to log in before you can comment on or make changes to this bug.