Bug 224449

Summary: Remove support for NPAPI plugins in WebView
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224441
Bug Depends on:    
Bug Blocks: 224441    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2021-04-12 13:30:30 PDT 
Remove support for NPAPI plugins in WebView
Comment 1 Alex Christensen 2021-04-12 13:32:17 PDT 
Created attachment 425782 [details]
Patch
Comment 2 Alex Christensen 2021-04-12 14:45:31 PDT 
Created attachment 425792 [details]
Patch
Comment 3 Chris Dumez 2021-04-12 14:48:51 PDT 
Comment on attachment 425792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425792&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:-903
> -    [self _setBoolValue: flag forKey: WebKitPluginsEnabledPreferenceKey];

Same comment as on the other patch. I think this should RELEASE_LOG_FAULT() when flag is YES to make issues more obvious in sysdiagnoses.

> Tools/DumpRenderTree/TestOptions.cpp:66
> +            { "PluginsEnabled", true },

Why was this moved out of PLATFORM(COCOA)?
Comment 4 Alex Christensen 2021-04-12 14:56:14 PDT 
Comment on attachment 425792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425792&action=review

>> Tools/DumpRenderTree/TestOptions.cpp:66
>> +            { "PluginsEnabled", true },
> 
> Why was this moved out of PLATFORM(COCOA)?

It was moved out of PLATFORM(WIN) to also apply to PLATFORM(COCOA)
Comment 5 Alex Christensen 2021-04-12 15:00:48 PDT 
Created attachment 425797 [details]
Patch
Comment 6 EWS 2021-04-13 14:21:03 PDT 
Committed r275912 (236476@main): <https://commits.webkit.org/236476@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425797 [details].
Comment 7 Radar WebKit Bug Importer 2021-04-13 14:22:15 PDT 
<rdar://problem/76610280>
Comment 8 Alex Christensen 2021-04-27 11:44:33 PDT 
This needs to be reverted because it caused rdar://77179042
Comment 9 Alex Christensen 2021-04-27 11:53:06 PDT 
http://trac.webkit.org/r276652
Comment 10 Alex Christensen 2021-04-27 13:29:26 PDT 
Reopening to attach new patch.
Comment 11 Alex Christensen 2021-04-27 13:29:28 PDT 
Created attachment 427187 [details]
Patch
Comment 12 Geoffrey Garen 2021-04-27 14:02:13 PDT 
Seems like Mac-wk1 needs updated test results
Comment 13 Alex Christensen 2021-04-27 15:43:19 PDT 
Created attachment 427206 [details]
Patch
Comment 14 Geoffrey Garen 2021-04-28 10:02:03 PDT 
Comment on attachment 427206 [details]
Patch

r=me
Comment 15 EWS 2021-04-28 10:19:41 PDT 
Committed r276720 (237124@main): <https://commits.webkit.org/237124@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427206 [details].