Bug 224442

Summary:

Test objects should know if they need servers

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

Tools / Tests

Assignee:

Sam Sneddon [:gsnedders] <gsnedders>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, glenn, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

220421

Attachments:

Description	Flags
Patch	none

Description Sam Sneddon [:gsnedders] 2021-04-12 10:45:57 PDT

Manager._is_http_test, Manager._needs_web_platform_test, Manager._is_websocket_test etc. should all be known by Test, and computed by the LayoutTestFinder. Alternate explanation: Manager shouldn't know about specific paths.

Comment 1 Sam Sneddon [:gsnedders] 2021-04-12 10:57:22 PDT

Created attachment 425766 [details]
Patch

Comment 2 EWS 2021-04-13 09:48:02 PDT

Committed r275888 (236453@main): <https://commits.webkit.org/236453@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425766 [details].

Comment 3 Radar WebKit Bug Importer 2021-04-13 09:54:23 PDT

<rdar://problem/76596286>