| Summary: | Move RuntimeEnabledFeatures to Settings (Part 1) | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, changseok, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, hi, hta, jer.noble, joepeck, kondapallykalyan, mmaxfield, philipj, sergio, simon.fraser, thorton, tommyw, webkit-bug-importer | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Sam Weinig
2021-04-12 09:17:57 PDT
Created attachment 425762 [details]
Patch
Created attachment 425764 [details]
Patch
Created attachment 425765 [details]
Patch
Created attachment 425783 [details]
Patch
Created attachment 425798 [details]
Patch
Created attachment 425799 [details]
Patch
I think what the test failures is showing is that the SettingsValues are not being propagated to service worker ScriptExecutationContexts. Created attachment 425878 [details]
Patch
Created attachment 425992 [details]
Patch
Comment on attachment 425992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425992&action=review > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1679 > + default: true It feels like this might also need to be WebCore::LibWebRTCProvider::webRTCAvailable but I'm not sure. Getting this wrong might affect the base system. In practice those values only effect svg image documents where I don’t think script can’t run, so I don’t think it matters in this case, but since I can use that I will make the change. Created attachment 426236 [details]
Patch
Patch 426236 does not build Created attachment 426306 [details]
Patch
Patch 426306 does not build (In reply to Sam Weinig from comment #11) > In practice those values only effect svg image documents where I don’t think > script can’t run, so I don’t think it matters in this case, but since I can > use that I will make the change. Lol, not so easy to make this change. Touché WebCore. Committed r276204 (236686@main): <https://commits.webkit.org/236686@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425992 [details]. |