Bug 224440

Summary: Move RuntimeEnabledFeatures to Settings (Part 1)
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, changseok, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, hi, hta, jer.noble, joepeck, kondapallykalyan, mmaxfield, philipj, sergio, simon.fraser, thorton, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2021-04-12 09:17:57 PDT
Move RuntimeEnabledFeatures to Settings (Part 1)
Attachments
Patch (111.34 KB, patch)
2021-04-12 10:05 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (111.26 KB, patch)
2021-04-12 10:25 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (111.26 KB, patch)
2021-04-12 10:52 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (114.54 KB, patch)
2021-04-12 13:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (114.78 KB, patch)
2021-04-12 15:07 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (115.08 KB, patch)
2021-04-12 15:27 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (111.69 KB, patch)
2021-04-13 09:52 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (110.97 KB, patch)
2021-04-14 09:01 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (111.01 KB, patch)
2021-04-16 09:30 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (111.49 KB, patch)
2021-04-16 18:29 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-04-12 10:05:20 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-04-12 10:25:44 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2021-04-12 10:52:48 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2021-04-12 13:38:41 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2021-04-12 15:07:02 PDT Comment hidden (obsolete)
Sam Weinig
Comment 6 2021-04-12 15:27:15 PDT Comment hidden (obsolete)
Sam Weinig
Comment 7 2021-04-13 06:58:30 PDT Comment hidden (obsolete)
Sam Weinig
Comment 8 2021-04-13 09:52:31 PDT Comment hidden (obsolete)
Sam Weinig
Comment 9 2021-04-14 09:01:02 PDT
Created attachment 425992 [details] Patch
Alex Christensen
Comment 10 2021-04-15 17:41:05 PDT
Comment on attachment 425992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425992&action=review > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1679 > + default: true It feels like this might also need to be WebCore::LibWebRTCProvider::webRTCAvailable but I'm not sure. Getting this wrong might affect the base system.
Sam Weinig
Comment 11 2021-04-16 08:52:17 PDT
In practice those values only effect svg image documents where I don’t think script can’t run, so I don’t think it matters in this case, but since I can use that I will make the change.
Sam Weinig
Comment 12 2021-04-16 09:30:17 PDT
Created attachment 426236 [details] Patch
EWS
Comment 13 2021-04-16 10:15:33 PDT
Patch 426236 does not build
Sam Weinig
Comment 14 2021-04-16 18:29:42 PDT
Created attachment 426306 [details] Patch
EWS
Comment 15 2021-04-16 19:26:02 PDT
Patch 426306 does not build
Sam Weinig
Comment 16 2021-04-17 09:17:39 PDT
(In reply to Sam Weinig from comment #11) > In practice those values only effect svg image documents where I don’t think > script can’t run, so I don’t think it matters in this case, but since I can > use that I will make the change. Lol, not so easy to make this change. Touché WebCore.
EWS
Comment 17 2021-04-17 13:07:39 PDT
Committed r276204 (236686@main): <https://commits.webkit.org/236686@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425992 [details].
Radar WebKit Bug Importer
Comment 18 2021-04-24 15:07:34 PDT
<rdar://problem/77110098>
Note You need to log in before you can comment on or make changes to this bug.