Bug 224430

Summary:

Add support for RTCEncodedFrame metadata

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description youenn fablet 2021-04-12 05:10:44 PDT

Add support for RTCEncodedFrame metadata

Comment 1 youenn fablet 2021-04-12 05:13:49 PDT

Created attachment 425735 [details]
Patch

Comment 2 youenn fablet 2021-04-12 05:52:13 PDT

Created attachment 425737 [details]
Patch

Comment 3 Eric Carlson 2021-04-12 09:40:32 PDT

Comment on attachment 425737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425737&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:114
> +    return { frameId, WTFMove(dependencies), metadata.GetWidth(), metadata.GetHeight(), metadata.GetSpatialIndex(), metadata.GetTemporalIndex(), m_rtcFrame->GetSsrc(), { } };

Will we eventually support contributingSources? If so, it would be good to have a bug and reference it here.

Comment 4 youenn fablet 2021-04-12 11:34:55 PDT

(In reply to Eric Carlson from comment #3)
> Comment on attachment 425737 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425737&action=review
> 
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:114
> > +    return { frameId, WTFMove(dependencies), metadata.GetWidth(), metadata.GetHeight(), metadata.GetSpatialIndex(), metadata.GetTemporalIndex(), m_rtcFrame->GetSsrc(), { } };
> 
> Will we eventually support contributingSources? If so, it would be good to
> have a bug and reference it here.

contributing sources is mostly for audio mixers where a server is mixing several audio in one stream but web page might still want to expose who is actually speaking.

I will file a bug to track it though since CSRC is not audio specific.

Comment 5 EWS 2021-04-12 11:45:35 PDT

Committed r275830 (236400@main): <https://commits.webkit.org/236400@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425737 [details].

Comment 6 Radar WebKit Bug Importer 2021-04-12 11:46:19 PDT

<rdar://problem/76549361>

Comment 7 youenn fablet 2021-04-13 02:03:37 PDT

> contributing sources is mostly for audio mixers where a server is mixing
> several audio in one stream but web page might still want to expose who is
> actually speaking.
> 
> I will file a bug to track it though since CSRC is not audio specific.

Let's make the attribute undefined if there are no CSRCs so that we do not surface it until we have something.