Summary: | REGRESSION(r275262) [WebDriver] Make automation JS code aware of injected script headers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
Component: | WebDriver | Assignee: | Lauro Moura <lmoura> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, bugs-noreply, cgarcia, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=223961 | ||||||||
Attachments: |
|
Description
Lauro Moura
2021-04-11 21:08:15 PDT
Created attachment 425718 [details]
Patch
Comment on attachment 425718 [details]
Patch
Is that comment useful tor WebDriver scripts? Maybe we could add an option to make-js-file-arrays.py not to include the directive and use that for WebDriver scripts?
(In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 425718 [details] > Patch > > Is that comment useful tor WebDriver scripts? Maybe we could add an option > to make-js-file-arrays.py not to include the directive and use that for > WebDriver scripts? I think it's not directly used by the WebDriver code, but intended for the inspector UI, so there is the scenario of pausing a webdriver session to inspect the code in the browser. In this case, IIUC, the directive should be present in the source. Comment on attachment 425718 [details]
Patch
the //# directive is a source map directive. It labels these evaluations, which is essential when debugging WebAutomationSessionProxy code via Web Inspector.
Perhaps you could search for the first non-comment line and wrap the remainder of the evaluation there, lifting any initial comments outside the async statement.
Created attachment 425789 [details]
Patch
Comment on attachment 425789 [details]
Patch
r=me
Committed r275915 (236479@main): <https://commits.webkit.org/236479@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425789 [details]. |