REGRESSION(r275755): [GStreamer] Crashes on surfaceless i915 platforms

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Philippe Normand]

Thread 18 (Thread 0x7f114f9519c0 (LWP 1311)):
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x00007f1151f54393 in g_cond_wait (cond=0x7f106000b898, mutex=0x7f106000b890) at ../glib/gthread-posix.c:1564
#2  0x00007f1150ebc634 in gst_gl_window_default_send_message (window=0x7f106000b8b0 [GstGLDummyWindow], callback=<optimized out>, data=<optimized out>) at ../gst-libs/gst/gl/gstglwindow.c:638
#3  0x00007f1150e9bb62 in gst_gl_context_thread_add (context=<optimized out>, func=0x7f1150e90800 <_mem_copy_gl>, data=0x7fff38106d20) at ../gst-libs/gst/gl/gstglcontext.c:1596
#4  0x00007f1150e90003 in _mem_copy (src=<optimized out>, offset=<optimized out>, size=<optimized out>) at ../gst-libs/gst/gl/gstglbasememory.c:422
#5  0x00007f115110df9a in gst_buffer_copy_into (dest=0x7f10ac058b40 [GstBuffer], src=src@entry=0x7f10d0056120 [GstBuffer], flags=flags@entry=(GST_BUFFER_COPY_FLAGS | GST_BUFFER_COPY_TIMESTAMPS | GST_BUFFER_COPY_META | GST_BUFFER_COPY_MEMORY | GST_BUFFER_COPY_DEEP), offset=offset@entry=0, size=480000, size@entry=18446744073709551615) at ../gst/gstbuffer.c:633
#6  0x00007f1151110a72 in gst_buffer_copy_with_flags (buffer=0x7f10d0056120 [GstBuffer], flags=(GST_BUFFER_COPY_FLAGS | GST_BUFFER_COPY_TIMESTAMPS | GST_BUFFER_COPY_META | GST_BUFFER_COPY_MEMORY | GST_BUFFER_COPY_DEEP)) at ../gst/gstbuffer.c:714
#7  0x00007f1159cb3b32 in _ZN7WebCore27MediaPlayerPrivateGStreamer18flushCurrentBufferEv () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#8  0x00007f1159ca4c3e in _ZZ38webKitGLVideoSinkSetMediaPlayerPrivateENUlP7_GstPadP16_GstPadProbeInfoPvE1_4_FUNES0_S2_S3_ () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
...
https://build.webkit.org/results/GTK-Linux-64-bit-Release-Wayland-Tests/r275806%20(959)/results.html exits early due to a crash in Mesa:

Thread 1 (Thread 0x7f10c27fe700 (LWP 8509)):
#0  dri2InvalidateDrawable (drawable=0x0) at ../src/mesa/drivers/dri/common/dri_util.c:866
#1  0x00007f11072abbc0 in intelDrawBuffer (ctx=0x7f10880016f0) at ../src/mesa/drivers/dri/i965/intel_buffers.c:45
#2  intelDrawBuffer (ctx=0x7f10880016f0) at ../src/mesa/drivers/dri/i965/intel_buffers.c:36
#3  0x00007f11073cdef9 in draw_buffer (no_error=false, caller=0x7f1107ba6532 "glDrawBuffer", buffer=1029, fb=0x7f1107fbd440 <IncompleteFramebuffer>, ctx=0x7f10880016f0) at ../src/mesa/main/buffers.c:326
#4  draw_buffer_error (ctx=0x7f10880016f0, fb=0x7f1107fbd440 <IncompleteFramebuffer>, buffer=1029, caller=0x7f1107ba6532 "glDrawBuffer") at ../src/mesa/main/buffers.c:337
#5  0x00007f1150ea65e7 in gst_gl_memory_copy_teximage (src=0x7f108808c8c0 [GstMemory], tex_id=861, out_target=<optimized out>, out_tex_format=<optimized out>, out_width=400, out_height=300) at ../gst-libs/gst/gl/gstglmemory.c:765
#6  0x00007f1150ea692c in _gl_tex_copy_thread (context=<optimized out>, data=0x7f10c27fd9a0) at ../gst-libs/gst/gl/gstglmemory.c:815
#7  0x00007f1150ea6a05 in gst_gl_memory_copy_into (gl_mem=gl_mem@entry=0x7f108808c8c0 [GstMemory], tex_id=<optimized out>, target=<optimized out>, tex_format=<optimized out>, width=<optimized out>, height=<optimized out>) at ../gst-libs/gst/gl/gstglmemory.c:1013
#8  0x00007f1150ea86b9 in _gl_mem_copy (src=0x7f108808c8c0 [GstMemory], offset=0, size=480000) at ../gst-libs/gst/gl/gstglmemorypbo.c:129
#9  0x00007f1150e90828 in _mem_copy_gl (context=<optimized out>, transfer=0x7fff38106d20) at ../gst-libs/gst/gl/gstglbasememory.c:408
#10 0x00007f1150ebb8d7 in _run_message_sync (message=0x7fff38106c90) at ../gst-libs/gst/gl/gstglwindow.c:612
#11 0x00007f1150ebb876 in _run_message_async (message=0x560ed64e84a0) at ../gst-libs/gst/gl/gstglwindow.c:679
#12 0x00007f1151effdbf in g_main_dispatch (context=0x7f109804c550) at ../glib/gmain.c:3337
#13 g_main_context_dispatch (context=0x7f109804c550) at ../glib/gmain.c:4055
#14 0x00007f1151f00168 in g_main_context_iterate (context=0x7f109804c550, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4131
#15 0x00007f1151f00483 in g_main_loop_run (loop=0x7f109804b800) at ../glib/gmain.c:4329
#16 0x00007f1150e9cc48 in gst_gl_context_create_thread (context=0x560ed6c00c40 [GstGLContextEGL]) at ../gst-libs/gst/gl/gstglcontext.c:1322
#17 0x00007f1151f2a5a1 in g_thread_proxy (data=0x7f106c009360) at ../glib/gthread.c:826
#18 0x00007f1151e8c4d2 in start_thread (arg=<optimized out>) at pthread_create.c:477
#19 0x00007f115197c323 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Upstream bug: https://gitlab.freedesktop.org/mesa/mesa/-/issues/778

[Philippe Normand]

Created attachment 425704 [details]
[fast-cq] Patch

[EWS]

Committed r276196 (236678@main): <https://commits.webkit.org/236678@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425704 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77110105>