Bug 224411

Summary: Update color-contrast() to support a target contrast ratio
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2021-04-10 19:35:00 PDT
Update color-contrast() to support a target contrast ratio
Attachments
Patch (12.19 KB, patch)
2021-04-10 19:44 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (12.19 KB, patch)
2021-04-11 09:32 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-04-10 19:44:14 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-04-11 09:32:52 PDT
Created attachment 425710 [details] Patch
EWS
Comment 3 2021-04-12 09:53:23 PDT
Committed r275826 (236396@main): <https://commits.webkit.org/236396@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425710 [details].
Radar WebKit Bug Importer
Comment 4 2021-04-12 09:54:14 PDT
<rdar://problem/76543214>
Darin Adler
Comment 5 2021-04-12 13:25:27 PDT
Comment on attachment 425710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425710&action=review > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1533 > + size_t indexOfColorWithHigestContrastRatio = 0; Could use a const Color* instead of an index, and then could switch to a range-based for loop. Or could use std::max_element instead of writing a loop.
Note You need to log in before you can comment on or make changes to this bug.