| Summary: | Force the WebAuthn compatible mode to always show UI | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, darin, garrett_davidson, jiewen_tan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jiewen Tan
2021-04-09 18:06:48 PDT
Created attachment 425672 [details]
Patch
Can you update the commit message with how you tested this? Comment on attachment 425672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:102 > +#if USE(APPLE_INTERNAL_SDK) Does this need a macOS check? or is it correct for iOS, too? Comment on attachment 425672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:102 >> +#if USE(APPLE_INTERNAL_SDK) > > Does this need a macOS check? or is it correct for iOS, too? This method is only used by the compatible mode which is now only on macOS. Committed r275847 (236412@main): <https://commits.webkit.org/236412@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425672 [details]. Comment on attachment 425672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:103 > + // A quirk to force the compatible mode to always show UI. This comment should say *why* we are doing this, not just say that "it’s a quirk". Comment on attachment 425672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:103 >> + // A quirk to force the compatible mode to always show UI. > > This comment should say *why* we are doing this, not just say that "it’s a quirk". I was trying to write a why here. But then it's hard to not reveal the feature and explain it clearly. Let me try rewrite it with a vague why. Land a comment fix per Darin's comment. Committed r275966: <https://commits.webkit.org/r275966> Committed r275966 (236519@main): <https://commits.webkit.org/236519@main> |