Bug 224391

Summary: Deprecate and remove most of _WKUserContentFilter
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Alex Christensen
Reported 2021-04-09 14:24:05 PDT
Deprecate and remove most of _WKUserContentFilter
Attachments
Patch (56.02 KB, patch)
2021-04-09 14:27 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (56.04 KB, patch)
2021-04-09 21:46 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (64.11 KB, patch)
2021-05-17 13:25 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-04-09 14:27:33 PDT
Created attachment 425654 [details] Patch
Alex Christensen
Comment 2 2021-04-09 21:46:21 PDT
Created attachment 425677 [details] Patch
Darin Adler
Comment 3 2021-04-10 11:59:57 PDT
Comment on attachment 425677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425677&action=review There seems to be an InstallAPI issue with the classes that are removed on iOS that needs to be addressed somehow. r=me assuming that’s worked out > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:31 > +IGNORE_WARNINGS_BEGIN("deprecated-implementations") Kind of surprised we don’t have a separate named macro for this one. > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:35 > +- (id)_initWithWKContentRuleList:(WKContentRuleList *)contentRuleList Not sure exactly how stubby to leave these stub classes. Could imagine also overriding init to return nil like this. > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:37 > + return nil; We ought to release or dealloc self before returning nil.
Radar WebKit Bug Importer
Comment 4 2021-04-16 14:25:15 PDT
<rdar://problem/76778414>
Alex Christensen
Comment 5 2021-05-17 13:15:04 PDT
Comment on attachment 425677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425677&action=review > Source/WebKit/ChangeLog:8 > + I removed its use in rdar://75889414 so we can remove most of it, but we still need a class with that name to launch SafariForWebKitDevelopment. SafariForWebKitDevelopment is already so broken from other things I can't test how much I need to leave, so I'm just going to remove all of it.
Alex Christensen
Comment 6 2021-05-17 13:25:08 PDT
Created attachment 428858 [details] Patch
EWS
Comment 7 2021-05-17 14:14:05 PDT
Committed r277605 (237822@main): <https://commits.webkit.org/237822@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428858 [details].
Alex Christensen
Comment 8 2021-05-17 17:29:51 PDT
This seems to have caused iOS test failures. Investigating...
Alex Christensen
Comment 9 2021-05-17 18:34:22 PDT
Very strange. All our test infrastructure doesn't seem to start any more after this change. Reverted in r277627
Alex Christensen
Comment 10 2022-09-01 11:22:07 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/3922
EWS
Comment 11 2022-09-01 23:06:10 PDT
Committed 254090@main (3d76e58f2afd): <https://commits.webkit.org/254090@main> Reviewed commits have been landed. Closing PR #3922 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.