Summary: | Deprecate and remove most of _WKUserContentFilter | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alex Christensen
2021-04-09 14:24:05 PDT
Created attachment 425654 [details]
Patch
Created attachment 425677 [details]
Patch
Comment on attachment 425677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425677&action=review There seems to be an InstallAPI issue with the classes that are removed on iOS that needs to be addressed somehow. r=me assuming that’s worked out > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:31 > +IGNORE_WARNINGS_BEGIN("deprecated-implementations") Kind of surprised we don’t have a separate named macro for this one. > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:35 > +- (id)_initWithWKContentRuleList:(WKContentRuleList *)contentRuleList Not sure exactly how stubby to leave these stub classes. Could imagine also overriding init to return nil like this. > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:37 > + return nil; We ought to release or dealloc self before returning nil. Comment on attachment 425677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425677&action=review > Source/WebKit/ChangeLog:8 > + I removed its use in rdar://75889414 so we can remove most of it, but we still need a class with that name to launch SafariForWebKitDevelopment. SafariForWebKitDevelopment is already so broken from other things I can't test how much I need to leave, so I'm just going to remove all of it. Created attachment 428858 [details]
Patch
Committed r277605 (237822@main): <https://commits.webkit.org/237822@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428858 [details]. This seems to have caused iOS test failures. Investigating... Very strange. All our test infrastructure doesn't seem to start any more after this change. Reverted in r277627 Re-opening for pull request https://github.com/WebKit/WebKit/pull/3922 Committed 254090@main (3d76e58f2afd): <https://commits.webkit.org/254090@main> Reviewed commits have been landed. Closing PR #3922 and removing active labels. |