Bug 224366

Summary:

[WPE][GTK] Use g_object_notify_by_pspec() whenever possible

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

WebKitGTK

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bugs-noreply, calvaris, cgarcia, ews-watchlist, gustavo, menard, pnormand, vjaquez

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adrian Perez 2021-04-09 05:52:37 PDT

In the WebKit code base, every single time we tell GObject to emit
a “notify::<propetyname>” signal we use “g_object_notify()”, which
will do a lookup for the property given its name. Ideally the code
should use “g_object_notify_by_pspec()” and avoid those lookups
altogether.

Comment 1 Adrian Perez 2021-04-10 14:36:25 PDT

Created attachment 425689 [details]
Patch

Comment 2 EWS Watchlist 2021-04-10 14:37:29 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 EWS 2021-04-12 01:13:24 PDT

Committed r275816 (236386@main): <https://commits.webkit.org/236386@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425689 [details].