Bug 224365

Summary: Use 3D points to map the WebXRBoundedReferenceSpace bounds transform
Product: WebKit Reporter: Imanol Fernandez <ifernandez>
Component: WebXRAssignee: Imanol Fernandez <ifernandez>
Severity: Normal CC: svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988    
Description Flags
Patch none

Description Imanol Fernandez 2021-04-09 04:41:59 PDT
WebXRBoundedReferenceSpace is currently using Point2D mapping to transfom the bounds geometry. This is not correct because the originOffset is a 3D transform and it expects the bounds depth coordinates to be on the z axis instead of the y axis.

There is a WPT test to reproduce this but we can't enable it yet until we fetch it from upstream (https://github.com/web-platform-tests/wpt/pull/28024), currently blocked by WebGL 2 support in WPE.
Comment 1 Imanol Fernandez 2021-04-09 04:51:20 PDT
Created attachment 425610 [details]
Comment 2 Sergio Villar Senin 2021-04-09 07:56:41 PDT
Comment on attachment 425610 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=425610&action=review

> Source/WebCore/ChangeLog:13
> +        currently blocked by WebGL 2 support in WPE.

WebGL2 shouldn't be a blocker for the testing of this kind of stuff. Why don't we just add a new small test to WPT to check this?
Comment 3 Radar WebKit Bug Importer 2021-04-16 04:42:13 PDT
Comment 4 Imanol Fernandez 2021-06-07 06:14:57 PDT
Created attachment 430740 [details]

Rebase onto main
Comment 5 EWS 2021-06-07 08:38:01 PDT
Committed r278562 (238560@main): <https://commits.webkit.org/238560@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430740 [details].