Bug 224360

Summary: [WPE] Enable Cog for developer builds
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WPE WebKitAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 225914    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Philippe Normand
Reported 2021-04-09 01:28:02 PDT
.
Attachments
Patch (1.40 KB, patch)
2021-04-09 01:33 PDT, Philippe Normand 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.36 KB, patch)
2021-04-09 01:38 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (5.57 KB, patch)
2021-04-28 07:40 PDT, Philippe Normand 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2021-04-28 07:43 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2021-04-28 09:21 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (3.67 KB, patch)
2021-06-10 07:53 PDT, Philippe Normand 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.67 KB, patch)
2021-06-10 08:10 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-04-09 01:33:01 PDT
Created attachment 425598 [details] Patch
Philippe Normand
Comment 2 2021-04-09 01:38:35 PDT
Created attachment 425599 [details] Patch
Philippe Normand
Comment 3 2021-04-09 01:50:37 PDT
oops FAILED: Tools/cog-prefix/src/cog-stamp/cog-download cd /app/webkit/Tools/wpe && /usr/bin/cmake -P /app/webkit/WebKitBuild/Release/Tools/cog-prefix/tmp/cog-gitclone.cmake && /usr/bin/cmake -E touch /app/webkit/WebKitBuild/Release/Tools/cog-prefix/src/cog-stamp/cog-download Cloning into 'cog'... fatal: unable to access 'https://github.com/Igalia/cog.git/': Could not resolve host: github.com Cloning into 'cog'... fatal: unable to access 'https://github.com/Igalia/cog.git/': Could not resolve host: github.com Cloning into 'cog'... fatal: unable to access 'https://github.com/Igalia/cog.git/': Could not resolve host: github.com -- Had to git clone more than once: 3 times. CMake Error at /app/webkit/WebKitBuild/Release/Tools/cog-prefix/tmp/cog-gitclone.cmake:31 (message): Failed to clone repository: 'https://github.com/Igalia/cog.git'
Philippe Normand
Comment 4 2021-04-13 04:31:26 PDT
Bad idea I guess.
Philippe Normand
Comment 5 2021-04-28 07:40:01 PDT
Reopening to attach new patch.
Philippe Normand
Comment 6 2021-04-28 07:40:05 PDT
Created attachment 427264 [details] Patch
Philippe Normand
Comment 7 2021-04-28 07:43:46 PDT
Created attachment 427265 [details] Patch
Philippe Normand
Comment 8 2021-04-28 09:21:34 PDT
Created attachment 427270 [details] Patch
Philippe Normand
Comment 9 2021-04-28 10:07:35 PDT
OK now it fails because SOUP2 is disabled: -- Checking for modules 'wpe-webkit-1.0>=2.28.0;wpe-1.0>=1.6.0' -- Package 'wpe-webkit-1.0', required by 'virtual:world', not found https://github.com/Igalia/cog/pull/299
Philippe Normand
Comment 10 2021-06-10 07:53:49 PDT
Created attachment 431080 [details] Patch
Philippe Normand
Comment 11 2021-06-10 08:10:27 PDT
Created attachment 431081 [details] Patch
Philippe Normand
Comment 12 2021-06-10 11:29:10 PDT
WPE EWS is green, building Cog with libsoup3 support. yee ahh
Adrian Perez
Comment 13 2021-06-10 11:56:22 PDT
Comment on attachment 431081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431081&action=review > Tools/PlatformWPE.cmake:34 > + CMAKE_ARGS "-DCOG_PLATFORM_GTK4=ON" "-DCOG_PLATFORM_HEADLESS=ON" "-DCOG_PLATFORM_X11=ON" "-DUSE_SOUP2=${USE_SOUP2}" Nice 🥣️
EWS
Comment 14 2021-06-10 12:24:58 PDT
Committed r278719 (238687@main): <https://commits.webkit.org/238687@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431081 [details].
Note You need to log in before you can comment on or make changes to this bug.