Bug 224338

Summary:

REGRESSION(r273541) WKWebView can't load NSURLRequest subclasses

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=222145

Attachments:

Description	Flags
Patch	none

Description Alex Christensen 2021-04-08 13:10:04 PDT

REGRESSION(r273541) WKWebView can't load NSURLRequest subclasses

Comment 1 Alex Christensen 2021-04-08 13:23:13 PDT

Created attachment 425538 [details]
Patch

Comment 2 Brent Fulgham 2021-04-08 14:26:10 PDT

Comment on attachment 425538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425538&action=review

A really nice fix. Thank you for solving this puzzle!

> Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:551
> +    if (Class requestClass = [requestToSerialize class]; UNLIKELY(requestClass != [NSURLRequest class] && requestClass != [NSMutableURLRequest class])) {

Could we add logging indicating what the unexpected class is? It would be interesting to know how widespread this weird use case is.

Comment 3 Brent Fulgham 2021-04-08 15:59:49 PDT

<rdar://problem/76192721>

Comment 4 EWS 2021-04-08 16:14:35 PDT

Committed r275687 (236321@main): <https://commits.webkit.org/236321@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425538 [details].