Bug 224286

Summary: Add webkit-patch support for fast-cq mode
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, glenn, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223954
https://bugs.webkit.org/show_bug.cgi?id=232196
Attachments:
Description Flags
Patch
none
[fast-cq] Patch none

Aakash Jain
Reported 2021-04-07 09:18:32 PDT
r275282 added fast-cq mode (for landing patches quickly through commit-queue by skipping building and testing). We should webkit-patch support for fast-cq mode. webkit-patch should have a --fast-cq parameter, which would result in uploaded patch being appropriately named on Bugzilla to trigger fast-cq mode.
Attachments
Patch (5.02 KB, patch)
2021-04-07 09:21 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (8.16 KB, patch)
2021-04-07 09:33 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-04-07 09:21:17 PDT Comment hidden (obsolete)
Aakash Jain
Comment 2 2021-04-07 09:33:43 PDT
Created attachment 425411 [details] [fast-cq] Patch
Alexey Proskuryakov
Comment 3 2021-04-07 09:44:18 PDT
This seems fine to do, but I don't really understand the goal. I understand that everything will be landed via commit queue on GitHub. But what exactly will we achieve by encouraging people to use CQ more now? Are you expecting that we'll still be using patch based workflow, so we need to find and fix all svn-apply bugs and limitations?
Aakash Jain
Comment 4 2021-04-07 11:20:00 PDT
(In reply to Alexey Proskuryakov from comment #3) > This seems fine to do, but I don't really understand the goal. I understand > that everything will be landed via commit queue on GitHub. But what exactly > will we achieve by encouraging people to use CQ more now? Are you expecting > that we'll still be using patch based workflow, so we need to find and fix > all svn-apply bugs and limitations? This comment seems more about Bug 223942. fast commit queue mode would be useful even in git world, since there would be various scenarios in which people would want to land quickly or skip building/testing, e.g.: build fix, typo fix, minor follow-up fix. For example, I just used this --fast-cq parameter to upload a patch for small follow-up fix in https://bugs.webkit.org/show_bug.cgi?id=223686#c14. I will discuss the concerns about Bug 223942 separately.
EWS
Comment 5 2021-04-08 13:02:59 PDT
Committed r275672 (236308@main): <https://commits.webkit.org/236308@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425411 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-08 13:03:34 PDT
<rdar://problem/76417274>
Note You need to log in before you can comment on or make changes to this bug.