Bug 224265

Summary: [METAL ANGLE] Interface block declerations need to have children marked as struct accesses. Add implicit backing textures for multisample render targets
Product: WebKit Reporter: John Cunningham <johncunningham>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description John Cunningham 2021-04-06 20:54:05 PDT 
[METAL ANGLE] Interface block declerations need to have children marked as struct accesses. Add implicit backing textures for multisample render targets
Comment 1 John Cunningham 2021-04-06 20:57:32 PDT 
Created attachment 425350 [details]
Patch
Comment 2 EWS Watchlist 2021-04-06 20:58:29 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 John Cunningham 2021-04-06 21:01:15 PDT 
Eventually this logic could be smarter. We may not always need to resolve and store the multisample texture, and the same for loading.
Comment 4 John Cunningham 2021-04-06 21:01:24 PDT 
Eventually this logic could be smarter. We may not always need to resolve and store the multisample texture, and the same for loading.
Comment 5 John Cunningham 2021-04-06 22:02:36 PDT 
Created attachment 425353 [details]
Patch
Comment 6 John Cunningham 2021-04-06 22:29:01 PDT 
Created attachment 425356 [details]
Patch
Comment 7 EWS 2021-04-07 12:00:37 PDT 
Committed r275617: <https://commits.webkit.org/r275617>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425356 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-07 12:02:35 PDT 
<rdar://problem/76359030>
Comment 9 Kyle Piddington 2021-04-07 12:15:21 PDT 
*** Bug 223922 has been marked as a duplicate of this bug. ***