Summary: | Add IPC::Semaphore stub for Unix ports | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebKit2 | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, don.olmstead, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kkinnunen, mmaxfield, philipj, ryuan.choi, sergio, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=223764 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2021-04-05 22:13:22 PDT
Created attachment 425242 [details]
Patch
Does the "scattering of ifdefs" have a substantial problem in context of WebKit, where ifdefs are used in general? I think the original intention was that the code "sort-of works" without the semaphore. So this takes it to "definitively does not work". Not that this choice would be bad, it may be better than what's currently in.. Yes, it seems the original intention. However, it didn't work as far as I tested. Unused code will become broken quickly. Sooner or later, Unix ports also should have the semaphore implementation. > However, it didn't work as far as I tested. Unused code will become broken quickly. Sounds like a good rationale. > Sooner or later, Unix ports also should have the semaphore implementation. Great! Created attachment 425314 [details]
Patch for landing
Comment on attachment 425314 [details] Patch for landing Clearing flags on attachment: 425314 Committed r275553 (236209@main): <https://commits.webkit.org/236209@main> All reviewed patches have been landed. Closing bug. |