Bug 224223

Summary: Add IPC::Semaphore stub for Unix ports
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit2Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, don.olmstead, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kkinnunen, mmaxfield, philipj, ryuan.choi, sergio, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223764
Attachments:
Description Flags
Patch
none
Patch for landing none

Fujii Hironori
Reported 2021-04-05 22:13:22 PDT
Add IPC::Semaphore stub for Unix ports
Attachments
Patch (27.40 KB, patch)
2021-04-05 22:19 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.17 KB, patch)
2021-04-06 13:04 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-04-05 22:19:26 PDT
Created attachment 425242 [details] Patch
Kimmo Kinnunen
Comment 2 2021-04-05 22:45:18 PDT
Does the "scattering of ifdefs" have a substantial problem in context of WebKit, where ifdefs are used in general? I think the original intention was that the code "sort-of works" without the semaphore. So this takes it to "definitively does not work". Not that this choice would be bad, it may be better than what's currently in..
Fujii Hironori
Comment 3 2021-04-05 23:43:48 PDT
Yes, it seems the original intention. However, it didn't work as far as I tested. Unused code will become broken quickly. Sooner or later, Unix ports also should have the semaphore implementation.
Kimmo Kinnunen
Comment 4 2021-04-05 23:59:32 PDT
> However, it didn't work as far as I tested. Unused code will become broken quickly. Sounds like a good rationale. > Sooner or later, Unix ports also should have the semaphore implementation. Great!
Fujii Hironori
Comment 5 2021-04-06 13:04:54 PDT
Created attachment 425314 [details] Patch for landing
Fujii Hironori
Comment 6 2021-04-06 14:27:26 PDT
Comment on attachment 425314 [details] Patch for landing Clearing flags on attachment: 425314 Committed r275553 (236209@main): <https://commits.webkit.org/236209@main>
Fujii Hironori
Comment 7 2021-04-06 14:27:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2021-04-06 14:28:24 PDT
<rdar://problem/76284505>
Note You need to log in before you can comment on or make changes to this bug.