Bug 224201

Summary: Web Inspector: Grid overlay areas appear offset from their actual areas when the grid container has a border set
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot of Issue
none
Screenshot of Patch v1.0
none
Patch v1.0 none

Patrick Angle
Reported 2021-04-05 13:15:06 PDT
There is a discrepancy in how the two axes are handled inside InspectorOverlay::buildGridOverlay where areas are not always taking the border of the grid container into account. Grid lines are correctly aligned in these situations, but the area borders are not.
Attachments
Screenshot of Issue (78.28 KB, image/png)
2021-04-05 13:50 PDT, Patrick Angle 		no flags
Details
Screenshot of Patch v1.0 (79.18 KB, image/png)
2021-04-05 13:50 PDT, Patrick Angle 		no flags
Details
Patch v1.0 (2.47 KB, patch)
2021-04-05 14:00 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick Angle
Comment 1 2021-04-05 13:50:17 PDT
Created attachment 425200 [details] Screenshot of Issue
Patrick Angle
Comment 2 2021-04-05 13:50:38 PDT
Created attachment 425201 [details] Screenshot of Patch v1.0
Patrick Angle
Comment 3 2021-04-05 14:00:47 PDT
Created attachment 425202 [details] Patch v1.0
Blaze Burg
Comment 4 2021-04-06 09:23:11 PDT
Comment on attachment 425202 [details] Patch v1.0 r=me, good catch
Patrick Angle
Comment 5 2021-04-06 10:02:59 PDT
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html has a history of flaky failure on mac-AS-debug-wk2 unrelated to this patch.
EWS
Comment 6 2021-04-06 10:18:57 PDT
Committed r275529: <https://commits.webkit.org/r275529> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425202 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-06 10:19:14 PDT
<rdar://problem/76272770>
Note You need to log in before you can comment on or make changes to this bug.