Bug 224181

Summary:	results.webkit.org displays svn revision even on selecting git hash
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED WONTFIX
Severity:	Normal	CC:	jbedard, ryanhaddad, tsavell, webkit-bot-watchers-bugzilla
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Aakash Jain 2021-04-05 04:45:38 PDT

results.webkit.org displays svn revision even on selecting git hash

To reproduce, open any test results, e.g.: https://results.webkit.org/?suite=layout-tests&test=fast%2Fanimation%2Fanimation-display-style-adjustment.html
change commit representation to 'hash'. 
Instead of hashes, revisions are displayed.

Comment 1 Aakash Jain 2021-04-05 04:46:35 PDT

If the hashes are not fully supported by the results.webkit.org UI yet, that option should not be shown.

Comment 2 Jonathan Bedard 2021-04-05 08:20:32 PDT

This is reflecting an issue that is ultimately temporary.

We compute the hash by consulting GitHub after retrieving the identifier. this process works but is apparently not consistent. The solution to this will be to report commits from your local checkout when running tests, we didn't want to do this with Subversion because retrieving commit messages in Subversion actually requires network operations. The reason I haven't made this change yet is because I have yet to deploy this change to the Internal results database, because I am populating branches before backfilling that database.

For the time being, I just manually backfilled the effected commits. I think periodically backfilling until we are reporting full commits is better than changing any code here.