Bug 224091

Summary: Non-unified build fixes, early April 2021
Product: WebKit Reporter: Tyler Wilcock <twilco.o>
Component: Tools / TestsAssignee: Tyler Wilcock <twilco.o>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, annulen, beidson, berto, cdumez, cgarcia, changseok, cmarcelo, darin, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, gustavo, gyuyoung.kim, hta, jamesr, japhet, jer.noble, jsbell, kangil.han, kondapallykalyan, luiz, mifenton, pdr, philipj, ryuan.choi, sam, sergio, simon.fraser, tommyw, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Follow-up patch
none
Follow-up patch
none
Follow-up patch none

Description Tyler Wilcock 2021-04-01 19:03:13 PDT 
(Need one of these fixes for https://bugs.webkit.org/show_bug.cgi?id=223150#c14, but I'll fix some of the other build errors too)
Comment 1 Tyler Wilcock 2021-04-01 19:27:41 PDT 
Created attachment 424976 [details]
Patch
Comment 2 Tyler Wilcock 2021-04-01 19:29:03 PDT 
Created attachment 424977 [details]
Patch
Comment 3 Tyler Wilcock 2021-04-01 19:58:43 PDT 
Created attachment 424982 [details]
Patch
Comment 4 EWS 2021-04-02 09:23:44 PDT 
Committed r275422: <https://commits.webkit.org/r275422>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424982 [details].
Comment 5 Radar WebKit Bug Importer 2021-04-02 09:24:13 PDT 
<rdar://problem/76150946>
Comment 6 Darin Adler 2021-04-02 13:14:42 PDT 
Comment on attachment 424982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424982&action=review

> Source/WebCore/ChangeLog:24
> +        * dom/EventContext.h:
> +        * dom/FocusOptions.h:

The ones that involve adding an include to a header are worth "struggling with" a little. Sometimes we can rearrange instead of adding the includes. Not worth it if it’s a .cpp file, but adding a header to a header can definitely contribute to overall project build time slowdown and blot.

> Source/WebCore/ChangeLog:32
> +        * workers/service/server/SWScriptStorage.h:
> +        * Modules/mediastream/RTCDataChannelRemoteSource.h:

Ditto.
Comment 7 Tyler Wilcock 2021-04-04 07:33:31 PDT 
Reopening to attach new patch.
Comment 8 Tyler Wilcock 2021-04-04 07:33:34 PDT 
Created attachment 425128 [details]
Follow-up patch
Comment 9 Tyler Wilcock 2021-04-04 07:40:00 PDT 
That's a good point, thanks -- I'll keep that in mind for the next one.  This follow-up patch should be an improvement.  An include of Document.h was added to FocusOptions.h just for a single enum (SelectionRestorationMode).  I split this enum out into a separate file so we don't have to do that anymore.
Comment 10 Tyler Wilcock 2021-04-04 10:21:19 PDT 
Created attachment 425130 [details]
Follow-up patch
Comment 11 Darin Adler 2021-04-05 09:29:03 PDT 
Comment on attachment 425130 [details]
Follow-up patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425130&action=review

> Source/WebCore/dom/Element.h:44
> +enum class SelectionRestorationMode : uint8_t;

We normally put enum forward declarations in their own separate paragraph after classes. Sort of “alphabetical order” with enum after class.
Comment 12 Tyler Wilcock 2021-04-05 10:30:42 PDT 
Created attachment 425170 [details]
Follow-up patch
Comment 13 EWS 2021-04-06 09:52:02 PDT 
Committed r275527: <https://commits.webkit.org/r275527>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425170 [details].