Summary: | [CMake][GStremer] Fails to build if OpenH264 is not present | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | WPE WebKit | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, bugs-noreply, calvaris, eric.carlson, ews-watchlist, gyuyoung.kim, mcatanzaro, pnormand, ryuan.choi, sergio, youennf | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=202538 | ||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2021-04-01 17:50:58 PDT
Created attachment 424970 [details]
Patch
Committed r275409: <https://commits.webkit.org/r275409> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424970 [details]. Will this still be needed in the gst-webrtc implementation? I wonder what the goal is. It looks like it is not compatible with noopenh264, right? If it was, and if it would still be needed with gst-webrtc, then I could look into packaging noopenh264 for Fedora, to allow this to build, but that requires runtime checks in the application to make sure you're running against real OpenH264 and not noopenh264. Why is it preferred over x264enc? (In reply to Michael Catanzaro from comment #3) > Will this still be needed in the gst-webrtc implementation? > > I wonder what the goal is. It looks like it is not compatible with > noopenh264, right? If it was, and if it would still be needed with > gst-webrtc, then I could look into packaging noopenh264 for Fedora, to allow > this to build, but that requires runtime checks in the application to make > sure you're running against real OpenH264 and not noopenh264. > > Why is it preferred over x264enc? This is for libwebrtc, which is not shipped on the tarballs, so I guess is not something a distributor should worry for the moment. I don't know why is preferred. Maybe ask on bug 202538 for that.. |