Bug 224051 – Web Inspector: Grid overlay does not honor writing modes and RTL layout direction.

• Component: Web Inspector
• Status: RESOLVED FIXED

[Patrick Angle]

Enabling a grid overlay on an element with a non-`normal` writing mode or with RTL direction set (via CSS or `dir` attribute) results in an overlay that may not line up with the underlying grid.

[Radar WebKit Bug Importer]

<rdar://problem/76106774>

[Patrick Angle]

Created attachment 425194 [details]
Patch v1.0

[Patrick Angle]

Comment on attachment 425194 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=425194&action=review

> Source/WebCore/inspector/InspectorOverlay.cpp:70
> +#include "WritingMode.h"

This import isn't needed any more for this patch.

[Patrick Angle]

Created attachment 425196 [details]
Video of Patch v1.0

[Blaze Burg]

Comment on attachment 425194 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=425194&action=review

r=me, nice work!

> Source/WebCore/inspector/InspectorOverlay.cpp:1673
> +            startPoint = { isWritingModeFlipped ? contentBox.width() - gridStartY : gridStartY, isDirectionFlipped ? contentBox.height() - x :x };

Nit: missing space in ':x'

[Patrick Angle]

Created attachment 425206 [details]
Patch v1.1 - Review notes

[EWS]

Committed r275519: <https://commits.webkit.org/r275519>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425206 [details].