Summary: | Make FontCache constructable and safe to use off the main thread | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Lord <clord> | ||||||
Component: | WebCore Misc. | Assignee: | Chris Lord <clord> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, cdumez, darin, mmaxfield, pvollan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 223995 | ||||||||
Bug Blocks: | 202793 | ||||||||
Attachments: |
|
Description
Chris Lord
2021-03-31 06:00:38 PDT
Created attachment 424834 [details]
Patch
Comment on attachment 424834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424834&action=review > Source/WebCore/platform/graphics/FontCache.h:41 > +#include <wtf/RefCounted.h> Should not need this if the header is including WTFString.h or AtomString.h > Source/WebCore/platform/graphics/FontCascadeFonts.cpp:491 > + ASSERT(m_thread.ptr() == &Thread::current()); Not sure this does the right thing with the web thread on iOS. > Source/WebCore/platform/graphics/FontCascadeFonts.h:117 > + Ref<Thread> m_thread { Thread::current() }; Should wrap this in #if ASSERT_ENABLED. > Source/WebCore/platform/graphics/FontCascadeFonts.h:129 > + ASSERT(m_thread.ptr() == &Thread::current()); Not sure this does the right thing with the web thread on iOS. Created attachment 424880 [details]
Patch
Committed r275364: <https://commits.webkit.org/r275364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424880 [details]. |