Bug 223997 – Make FontCache constructable and safe to use off the main thread

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Lord]

For OffscreenCanvas to have its own FontCache separate from the main FontCache singleton, FontCache needs to be constructable and its methods safe to use off the main thread.

[Chris Lord]

Created attachment 424834 [details]
Patch

[Darin Adler]

Comment on attachment 424834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424834&action=review

> Source/WebCore/platform/graphics/FontCache.h:41
> +#include <wtf/RefCounted.h>

Should not need this if the header is including WTFString.h or AtomString.h

> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:491
> +    ASSERT(m_thread.ptr() == &Thread::current());

Not sure this does the right thing with the web thread on iOS.

> Source/WebCore/platform/graphics/FontCascadeFonts.h:117
> +    Ref<Thread> m_thread { Thread::current() };

Should wrap this in #if ASSERT_ENABLED.

> Source/WebCore/platform/graphics/FontCascadeFonts.h:129
> +    ASSERT(m_thread.ptr() == &Thread::current());

Not sure this does the right thing with the web thread on iOS.

[Chris Lord]

Created attachment 424880 [details]
Patch

[EWS]

Committed r275364: <https://commits.webkit.org/r275364>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424880 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76106447>