Summary: | Make FontCache self-contained (remove static global variables) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Lord <clord> | ||||||
Component: | WebCore Misc. | Assignee: | Chris Lord <clord> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, ews-watchlist, mmaxfield, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 202793, 223997 | ||||||||
Attachments: |
|
Description
Chris Lord
2021-03-31 05:43:12 PDT
Created attachment 424762 [details]
Patch
Comment on attachment 424762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424762&action=review > Source/WebCore/platform/graphics/FontCache.h:299 > + struct FontPlatformDataCacheKey { If we want to keep this all out of the header, we can put these things into a structure in a WTF::UniqueRef instead of directly into the FontCache object itself. Uses a little more memory, but helps keep the FontCache.h file smaller. Created attachment 424820 [details]
Patch
Comment on attachment 424820 [details]
Patch
Comment addressed.
Committed r275308: <https://commits.webkit.org/r275308> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424820 [details]. |