Bug 223953

Summary: Optimize constructors of ES6 collections
Product: WebKit Reporter: Alexey Shvayka <shvaikalesh>
Component: JavaScriptCoreAssignee: Alexey Shvayka <shvaikalesh>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ews-watchlist, keith_miller, mark.lam, msaboff, sbarati, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Alexey Shvayka 2021-03-30 13:30:54 PDT
Optimize constructors of ES6 collections
Comment 1 Alexey Shvayka 2021-03-30 13:34:39 PDT
Created attachment 424684 [details]
Patch
Comment 2 Alexey Shvayka 2021-03-30 13:35:37 PDT
(In reply to Alexey Shvayka from comment #1)
> Created attachment 424684 [details]
> Patch

                               r274330                     patch

map-constructor            58.2210+-1.2994     ^     30.8037+-2.3228        ^ definitely 1.8901x faster
set-constructor            45.7864+-0.7473     ^     24.6108+-0.5660        ^ definitely 1.8604x faster
weak-map-constructor       49.8301+-1.0494     ^     20.1428+-0.3565        ^ definitely 2.4738x faster
weak-set-constructor       33.8521+-0.5850     ^     14.6234+-0.7491        ^ definitely 2.3149x faster

<geometric>                45.9778+-0.4459     ^     21.5779+-0.3504        ^ definitely 2.1308x faster
Comment 3 Yusuke Suzuki 2021-03-30 13:46:00 PDT
Comment on attachment 424684 [details]
Patch

r=me, nice!!!
Comment 4 Alexey Shvayka 2021-03-31 00:16:42 PDT
(In reply to Yusuke Suzuki from comment #3)
> Comment on attachment 424684 [details]
> Patch
> 
> r=me, nice!!!

Thank you for review!
Comment 5 EWS 2021-03-31 00:21:41 PDT
Committed r275271: <https://commits.webkit.org/r275271>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424684 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-31 00:22:14 PDT
<rdar://problem/76041677>