Bug 223949

Summary: [ macOS iOS ] crypto/crypto-random-values-oom.html is a flakey timeout
Product: WebKit Reporter: Robert Jenner <jenner>
Component: WebCore Misc.Assignee: ayumi_kojima
Status: RESOLVED FIXED    
Severity: Normal CC: amir_mark, ayumi_kojima, jiewen_tan, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update Expectations none

Description Robert Jenner 2021-03-30 12:58:12 PDT 
crypto/crypto-random-values-oom.html

is a flakey timeout on iOS 14 Debug, and macOS Catalina and higher. 

Most timeouts for macOS occur on BigSur DebugwWk1 and wk2 on apple silicon mostly. But the history shows flakey timeouts occurring for a while on Catalina in release for wk1 and wk2. The timeouts appear more frequent in iOS and on Apple Silicon. 

HISTORY URL:
https://results.webkit.org/?suite=layout-tests&test=crypto%2Fcrypto-random-values-oom.html

Could not obtain a Timeout Diff, as even the most recent record for the timeout diff on the Layout-test results page results in a 404 error.
Comment 1 Robert Jenner 2021-03-30 13:58:44 PDT 
Was able to reproduce the timeout on Catalina wk2 Release ToT using the following test:

run-webkit-test crypto/crypto-random-values-oom.html --iterations 1000 -f

Here is the text diff that was generated from reproducing the timeout:

PASS exceptionString == undefined || exceptionString === "TypeError: Argument 1 ('array') to Crypto.getRandomValues must be an instance of ArrayBufferView" is true
PASS crypto.getRandomValues didn't crash
PASS successfullyParsed is true

TEST COMPLETE
Comment 2 Radar WebKit Bug Importer 2021-03-30 13:59:02 PDT 
<rdar://problem/76020524>
Comment 3 Robert Jenner 2021-03-30 14:16:16 PDT 
Updated test expectations here to Pass Timeout while test is reviewed: 
https://trac.webkit.org/changeset/275234/webkit
Comment 4 Ryan Haddad 2021-05-26 12:41:18 PDT 
It looks like this test was marked as slow in https://commits.webkit.org/237437@main, but it is still timing out on the bots.
Comment 5 Amir Mark Jr 2021-05-26 14:36:21 PDT 
Updated the test expectations back to Pass Timeout due to test still appearing flaky:

https://trac.webkit.org/changeset/278126/webkit
Comment 6 ayumi_kojima 2021-07-19 16:27:14 PDT 
Created attachment 433832 [details]
Update Expectations
Comment 7 ayumi_kojima 2021-07-19 16:28:47 PDT 
Updating the test expectations for iOS simulator back to Pass Timeout due to test still appearing flaky
Comment 8 Robert Jenner 2021-07-19 16:35:45 PDT 
Comment on attachment 433832 [details]
Update Expectations

Clearing flags on attachment: 433832

Committed r280054 (239789@main): <https://commits.webkit.org/239789@main>
Comment 9 Vitaly Dyackhov 2024-05-29 08:06:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29220
Comment 10 EWS 2024-06-05 02:36:37 PDT 
Committed 279733@main (e9b4df324f0c): <https://commits.webkit.org/279733@main>

Reviewed commits have been landed. Closing PR #29220 and removing active labels.