Bug 223941

Summary: Services EWS should run for webkitscmpy and webkitcorepy changes
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch
none
[fast-cq] Patch none

Description Aakash Jain 2021-03-30 11:14:53 PDT 
Services EWS should run tests for webkitscmpy changes, since webkitscmpy changes can break resultsdbpy tests.

As noted in https://bugs.webkit.org/show_bug.cgi?id=223397#c5, r274587 broke resultsdbpy tests, but Services EWS was not run on that patch.
Comment 1 Radar WebKit Bug Importer 2021-04-06 11:16:16 PDT 
<rdar://problem/76275638>
Comment 2 Aakash Jain 2021-04-21 16:33:44 PDT 
Created attachment 426753 [details]
[fast-cq] Patch
Comment 3 Jonathan Bedard 2021-04-22 07:58:01 PDT 
Comment on attachment 426753 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426753&action=review

> Tools/CISupport/ews-build/steps.py:377
> +        'Tools/Scripts/libraries/webkitscmpy',

Probably webkitcorepy too, since webkitscmpy uses webkitcorepy.
Comment 4 Aakash Jain 2021-04-22 09:08:54 PDT 
Created attachment 426819 [details]
[fast-cq] Patch
Comment 5 EWS 2021-04-22 09:12:44 PDT 
Committed r276438 (236901@main): <https://commits.webkit.org/236901@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426819 [details].