Bug 223927

Summary: Computed style for a border-radius corner should never be 0px when the provided width isn't 0px
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Description Antoine Quint 2021-03-30 06:34:47 PDT
Computed style for a border-radius corner should never be 0px when the provided width isn't 0px
Comment 1 Antoine Quint 2021-03-30 06:36:55 PDT
Created attachment 424634 [details]
Patch
Comment 2 Dean Jackson 2021-03-30 12:27:39 PDT
Comment on attachment 424634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424634&action=review

> Source/WebCore/ChangeLog:10
> +        If "border-top-left-radius: 40px 0px" is provided, the computed style would return "0px" since
> +        BuilderConverter::convertRadius() would treat either of the dimensions for the radius being 0
> +        as both being 0.

Please add a computed style test as well. This should not only be tested by animations.
Comment 3 Antoine Quint 2021-03-31 00:00:09 PDT
(In reply to Dean Jackson from comment #2)
> Please add a computed style test as well. This should not only be tested by
> animations.

I added an assertion to the WPT border-radius computed style test, see https://github.com/web-platform-tests/wpt/pull/28310.
Comment 4 Antoine Quint 2021-03-31 01:30:55 PDT
Committed r275273 (235958@main): <https://commits.webkit.org/235958@main>
Comment 5 Radar WebKit Bug Importer 2021-03-31 01:31:13 PDT
<rdar://problem/76043529>