Bug 223888

Summary: [GStreamer] Test harness should use a mock audio output device
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, ews-watchlist, glenn, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 224053    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Philippe Normand 2021-03-29 11:32:37 PDT
Since ~ 2012 we have a script called "pulseaudio_sanitizer" which unloads/loads some restore-stream module. This is not working at all with pipewire-pulse. Besides, having to bear with beeps and boops when running tests on a desktop machine is a bit annoying.

Proposal: Use a fakeaudiosink element, up-ranked when running the test harness, so that it is picked up by autoaudiosink.
Comment 1 Philippe Normand 2021-04-01 09:58:49 PDT
Created attachment 424910 [details]
Patch
Comment 2 Adrian Perez 2021-04-01 11:44:41 PDT
Comment on attachment 424910 [details]
Patch

Good one, and nice to see some code go the way of the dodo, too =)
Comment 3 EWS 2021-04-06 06:38:20 PDT
Committed r275513: <https://commits.webkit.org/r275513>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424910 [details].