| Summary: | Style checker should warn about use of future OS versions in WK_API_AVAILABLE | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | BJ Burg <bburg> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bburg, ews-watchlist, glenn, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Simon Fraser (smfr)
2021-03-29 10:10:18 PDT
Created attachment 424606 [details]
Patch v1.0
Comment on attachment 424606 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=424606&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:3309 > + MAX_ALLOWED_MACOS_VERSION = 11.0 We have these hard-coded in Tools/Scripts/webkitpy/common/version_name_map.py, we're trying to centralize versions for this sort of thing in that file Comment on attachment 424606 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=424606&action=review > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:51 > +# Enable this if you need to see the full diff when debugging failures. Did you intend to include this as part of the change? Created attachment 424614 [details]
Patch v1.1, turn off debugging code by default
(In reply to Jonathan Bedard from comment #2) > Comment on attachment 424606 [details] > Patch v1.0 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424606&action=review > > > Tools/Scripts/webkitpy/style/checkers/cpp.py:3309 > > + MAX_ALLOWED_MACOS_VERSION = 11.0 > > We have these hard-coded in > Tools/Scripts/webkitpy/common/version_name_map.py, we're trying to > centralize versions for this sort of thing in that file OK, will take a peep. Created attachment 424654 [details]
Patch v2.1 - use Version / VersionNameMap to parse and compare version numbers
Created attachment 424655 [details]
Patch v2.1 - use Version / VersionNameMap to parse and compare version numbers
Comment on attachment 424655 [details] Patch v2.1 - use Version / VersionNameMap to parse and compare version numbers View in context: https://bugs.webkit.org/attachment.cgi?id=424655&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:3314 > + if platform_name == "macos": I think we should make this a loop through a dictionary so we can support other platforms (namely watchOS) and de-duplicate code. Looking through the differences between iOS and macOS, should reduce the size of this function too > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:51 > +# Enable this if you need to see the full diff when debugging failures. I think we should put this in a different change Created attachment 424829 [details]
Patch v3.0
incorporated latest feedback from jbedard.
Committed r275313: <https://commits.webkit.org/r275313> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424829 [details]. |