Summary: | [WinCairo] Custom fonts don't work in GPU process mode | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, don.olmstead, ews-watchlist, gyuyoung.kim, mmaxfield, pvollan, ryuan.choi, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fujii Hironori
2021-03-28 20:02:04 PDT
Created attachment 424520 [details]
Patch
Created attachment 424529 [details]
Patch
Comment on attachment 424529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424529&action=review > Source/WebCore/platform/graphics/opentype/FontMemoryResource.h:55 > + HANDLE m_fontResourceHandle; Do you have plans to make this class cross platform? If not maybe it should be in a win directory. Comment on attachment 424529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424529&action=review Thank you very much. >> Source/WebCore/platform/graphics/opentype/FontMemoryResource.h:55 >> + HANDLE m_fontResourceHandle; > > Do you have plans to make this class cross platform? > > If not maybe it should be in a win directory. Yes, that mattered to me. However, I put it in the 'opentype' directory. Because OpenTypeUtilities.{h, cpp} also Windows specific and FontMemoryResource are used mainly by them. If I put FontMemoryResource.h in 'win' directory, source files in 'win' directory include OpenTypeUtilities.h and it includes FontMemoryResource.h in 'win' directory. This bi-directional inclusion doesn't make me take the approach. Comment on attachment 424529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424529&action=review >>> Source/WebCore/platform/graphics/opentype/FontMemoryResource.h:55 >>> + HANDLE m_fontResourceHandle; >> >> Do you have plans to make this class cross platform? >> >> If not maybe it should be in a win directory. > > Yes, that mattered to me. However, I put it in the 'opentype' directory. > Because OpenTypeUtilities.{h, cpp} also Windows specific and FontMemoryResource are used mainly by them. > If I put FontMemoryResource.h in 'win' directory, source files in 'win' directory include OpenTypeUtilities.h and it includes FontMemoryResource.h in 'win' directory. > This bi-directional inclusion doesn't make me take the approach. I don't have the plan. Comment on attachment 424529 [details] Patch Clearing flags on attachment: 424529 Committed r275174 (235877@main): <https://commits.webkit.org/235877@main> All reviewed patches have been landed. Closing bug. |