Bug 223854

Summary: [macOS] Add remote MediaSessionCoordinator
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, glenn, gyuyoung.kim, hi, jer.noble, mkwst, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
ews-feeder: commit-queue-
WIP patch
none
Patch for landing
none
Patch for landing ews-feeder: commit-queue-

Eric Carlson
Reported 2021-03-28 13:32:44 PDT
Add remote MediaSessionCoordinator
Attachments
WIP patch (112.67 KB, patch)
2021-03-28 14:12 PDT, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP patch (112.81 KB, patch)
2021-03-28 15:06 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (112.80 KB, patch)
2021-03-29 11:10 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (113.06 KB, patch)
2021-03-29 11:21 PDT, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-28 13:32:52 PDT
<rdar://problem/75934650>
Eric Carlson
Comment 2 2021-03-28 14:12:08 PDT
Created attachment 424509 [details] WIP patch
Eric Carlson
Comment 3 2021-03-28 15:06:30 PDT
Created attachment 424510 [details] WIP patch
Jer Noble
Comment 4 2021-03-29 10:09:38 PDT
These changes all LGTM, but we should think about decoupling the successful MediaSessionCoordinatorPrivate callback from a default MediaSession action in response. I can imagine a situation where a promise has to get rejected because a pause command came in while a play coordination request was still waiting to be fulfilled. Maybe in a follow-up patch we could take a look at this.
Jer Noble
Comment 5 2021-03-29 10:55:06 PDT
Comment on attachment 424510 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=424510&action=review > Source/WebCore/ChangeLog:8 > +2021-03-28 Eric Carlson <eric.carlson@apple.com> > + > + [macOS] Add remote MediaSessionCoordinator > + https://bugs.webkit.org/show_bug.cgi?id=223854 > + <rdar://problem/75934650> > + > + Reviewed by NOBODY (OOPS!). > + Please fill out the ChangeLog description before landing.
Eric Carlson
Comment 6 2021-03-29 11:10:26 PDT
Created attachment 424550 [details] Patch for landing
Eric Carlson
Comment 7 2021-03-29 11:21:13 PDT
Created attachment 424553 [details] Patch for landing
Eric Carlson
Comment 8 2021-03-29 13:03:53 PDT
Comment on attachment 424553 [details] Patch for landing The Mac test bot failure is media/media-fragments/TC0051.html, not related.
EWS
Comment 9 2021-03-29 13:20:43 PDT
Committed r275171: <https://commits.webkit.org/r275171> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424553 [details].
Note You need to log in before you can comment on or make changes to this bug.