Bug 223854

Summary: [macOS] Add remote MediaSessionCoordinator
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, drousso, ews-watchlist, glenn, gyuyoung.kim, jer.noble, mkwst, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
ews-feeder: commit-queue-
WIP patch
none
Patch for landing
none
Patch for landing ews-feeder: commit-queue-

Description Eric Carlson 2021-03-28 13:32:44 PDT
Add remote MediaSessionCoordinator
Comment 1 Radar WebKit Bug Importer 2021-03-28 13:32:52 PDT
<rdar://problem/75934650>
Comment 2 Eric Carlson 2021-03-28 14:12:08 PDT
Created attachment 424509 [details]
WIP patch
Comment 3 Eric Carlson 2021-03-28 15:06:30 PDT
Created attachment 424510 [details]
WIP patch
Comment 4 Jer Noble 2021-03-29 10:09:38 PDT
These changes all LGTM, but we should think about decoupling the successful MediaSessionCoordinatorPrivate callback from a default MediaSession action in response. I can imagine a situation where a promise has to get rejected because a pause command came in while a play coordination request was still waiting to be fulfilled. Maybe in a follow-up patch we could take a look at this.
Comment 5 Jer Noble 2021-03-29 10:55:06 PDT
Comment on attachment 424510 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424510&action=review

> Source/WebCore/ChangeLog:8
> +2021-03-28  Eric Carlson  <eric.carlson@apple.com>
> +
> +        [macOS] Add remote MediaSessionCoordinator
> +        https://bugs.webkit.org/show_bug.cgi?id=223854
> +        <rdar://problem/75934650>
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Please fill out the ChangeLog description before landing.
Comment 6 Eric Carlson 2021-03-29 11:10:26 PDT
Created attachment 424550 [details]
Patch for landing
Comment 7 Eric Carlson 2021-03-29 11:21:13 PDT
Created attachment 424553 [details]
Patch for landing
Comment 8 Eric Carlson 2021-03-29 13:03:53 PDT
Comment on attachment 424553 [details]
Patch for landing

The Mac test bot failure is media/media-fragments/TC0051.html, not related.
Comment 9 EWS 2021-03-29 13:20:43 PDT
Committed r275171: <https://commits.webkit.org/r275171>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424553 [details].